Type f not supported bug fix
#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While ImmuDB supports `FLOAT` types in data tables when working with SQL, the Python SDK had missing implementations for this. For more detail see issue issue-76. Signed-off-by: Henrik <[email protected]>
Contributor
|
Hey, @VHenrik007, thank you for your fix. Just to make sure we cover the new lines of code, could you please add an SDK test which queries a column of type float? |
Contributor
Author
|
Hi @ostafen ! |
A simpler and a more comprehensive test covering the insertion, querying, aggregation and filtering features for floating point numbers using SQL.
Float got introduced in immudb version 1.5.0: https://github.com/codenotary/immudb/blob/v1.5.0/CHANGELOG.md#features Currently tests run on older versions as well, so this version check is added as seen in `test_sql_verify.py` for example, where it was handled simply by returning.
Contributor
|
Thank you, @VHenrik007, we appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ImmuDB supports
FLOATtypes in data tables when working with SQL, the Python SDK had missing implementations for this. For more detail see issue issue #76