Skip to content

add index label to prometheus metric #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

add index label to prometheus metric #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8012416
add index label to prometheus metric
SimoneLazzaris Feb 14, 2025
d43b9d7
add test for indexer
SimoneLazzaris Feb 14, 2025
2c56e00
suppress sonarqube warning on non crypto rand
SimoneLazzaris Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions embedded/store/indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,14 @@ var (
Help: "The highest id of indexed transaction",
}, []string{
"db",
"index",
})
metricsLastCommittedTrx = promauto.NewGaugeVec(prometheus.GaugeOpts{
Name: "immudb_last_committed_trx_id",
Help: "The highest id of committed transaction",
}, []string{
"db",
"index",
})
)

Expand Down Expand Up @@ -179,8 +181,9 @@ func newIndexer(path string, store *ImmuStore, opts *Options) (*indexer, error)
}

dbName := filepath.Base(store.path)
indexer.metricsLastIndexedTrx = metricsLastIndexedTrxId.WithLabelValues(dbName)
indexer.metricsLastCommittedTrx = metricsLastCommittedTrx.WithLabelValues(dbName)
idxName := filepath.Base(path)
indexer.metricsLastIndexedTrx = metricsLastIndexedTrxId.WithLabelValues(dbName, idxName)
indexer.metricsLastCommittedTrx = metricsLastCommittedTrx.WithLabelValues(dbName, idxName)

return indexer, nil
}
Expand Down Expand Up @@ -498,7 +501,7 @@ func (idx *indexer) handleWriteStalling(err error) error {
if err := idx.store.FlushIndexes(0, false); err != nil {
return err
}

// NOSONAR (rand is fine here)
sleepTime := writeStallingSleepDurationMin + time.Duration(rand.Intn(int(writeStallingSleepDurationMax-writeStallingSleepDurationMin+1)))
time.Sleep(sleepTime)
return nil
Expand Down
7 changes: 7 additions & 0 deletions embedded/store/indexer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ func TestNewIndexerFailure(t *testing.T) {
require.ErrorIs(t, err, ErrIllegalArguments)
}

func TestNewIndexer(t *testing.T) {
stor := ImmuStore{}
indexer, err := newIndexer(t.TempDir(), &stor, DefaultOptions())
require.Nil(t, err)
require.NotNil(t, indexer)
}

func TestClosedIndexerFailures(t *testing.T) {
store, err := Open(t.TempDir(), DefaultOptions().WithIndexOptions(
DefaultIndexOptions().WithCompactionThld(1),
Expand Down
Loading