feat: Issue #1 - Add ability to remove profile picture #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'Remove' button to account settings UI below profile picture - Button only appears when user has an uploaded profile picture - Clicking button removes picture and reverts to default avatar - Update update_profile() helper to handle profile field deletion - Style button with button-danger class for consistent UI Changes: * UITabAccount.js: Add remove button UI, click handler, and show/hide logic * helpers.js: Update update_profile() to delete fields when value is null The button is styled as a danger action (red background, white text) and disappears after removing the picture or when no picture exists.
- Add translations for all 38 supported languages
- Add UIAlert confirmation dialog when user attempts to remove profile picture - Implement flag to prevent multiple simultaneous removal operations - Add backdrop overlay to block interactions during confirmation - Change remove button style from 'primary' to 'danger' for better UX - Add 'confirm_remove_profile_picture' translation key to all 37 language files Changes: - src/gui/src/UI/Settings/UITabAccount.js: * Import UIAlert component * Add is_removing_profile_picture flag to prevent race conditions * Wrap removal logic in try-finally block for proper cleanup * Add confirmation dialog with backdrop and danger-styled button - src/gui/src/i18n/translations/*.js: * Add confirmation message in 37 languages * Message: 'Are you sure you want to remove your profile picture?'
israx
reviewed
Oct 21, 2025
| profile[key] = key_vals[key]; | ||
| // update window.user.profile | ||
| window.user.profile[key] = key_vals[key]; | ||
| if (key_vals[key] === null || key_vals[key] === undefined || key_vals[key] === '') { |
There was a problem hiding this comment.
Nit: null , undefined and '' are falsy values, which means we can substitute code above by
Suggested change
| if (key_vals[key] === null || key_vals[key] === undefined || key_vals[key] === '') { | |
| if (!!key_vals[key]) { |
israx
reviewed
Oct 21, 2025
| h += `<div class="profile-picture change-profile-picture" style="background-image: url('${html_encode(window.user?.profile?.picture ?? window.icons['profile.svg'])}');">`; | ||
| h += `</div>`; | ||
| h += `</div>`; | ||
| h += `<div style="text-align: center; margin-bottom: 20px;">`; |
There was a problem hiding this comment.
Nit:
Let's make sure we are being consistent with styles here. We should establish a boundary when to use inline-styles vs css.
inline-styles can be beneficial for referring to javascript code such as the profile picture online 39.
israx
reviewed
Oct 21, 2025
|
|
||
| $el_window.find('.remove-profile-picture').on('click', async function (e) { | ||
| // Prevent multiple simultaneous operations | ||
| if(is_removing_profile_picture) |
There was a problem hiding this comment.
Nit:
Ideally, instead of deduping this call, we should disable the remove profile picture button while the picture is being deleted
israx
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "Remove" button to account settings, which allows users to delete their profile picture and revert to the default avatar.
Before
After
Implementation
Related Issue
Closes Issue #1 - Add ability to remove profile picture #5
Changes Made
Core Functionality
update_profile()helper function to support field deletionbutton-dangerclass) for consistencyInternationalization
remove_profile_picture/confirm_remove_profile_picturetranslation key to all 38 supported languagesImplementation Details
{picture: null}toupdate_profile()picturefield from/{username}/Public/.profileJSON fileTesting Performed
Files Modified
src/gui/src/helpers.js- Profile deletion logicsrc/gui/src/UI/Settings/UITabAccount.js- UI components and event handlerssrc/gui/src/i18n/translations/*.js- All 38 translation files