fix(table): add Prev/Next and improve pagination paddings #22

guechhouth · 2025-10-19T04:21:14Z

SUMMARY

Add Prev/Next controls to table pagination for better UX and navigation
Normalize spacing between pagination items using theme tokens (flex + gap)
Files changed:
- Pagination.tsx: Add Prev/Next buttons with accessibility attributes
- Styles.tsx: Update to flex layout with theme-based spacing

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

Open any table chart in Explore view
Verify Prev/Next buttons:
- Appear and function correctly
- Disabled states work (first/last page)
Check spacing is consistent between pagination items
Verify sticky table behavior still works correctly

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…#32064) (cherry picked from commit cde2d49)

…e#32040) (cherry picked from commit 0cd0fcd)

…pache#32133) (cherry picked from commit 53d944d)

(cherry picked from commit 8984f88)

…e#32135) (cherry picked from commit c64018d)

(cherry picked from commit c7c3b1b)

…2151) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ea5879b)

…e#32155) (cherry picked from commit 6ed9dae)

(cherry picked from commit e8990f4)

(cherry picked from commit 5a8488a)

… the SQL query (apache#30903) Co-authored-by: Kamil Gabryjelski <[email protected]> (cherry picked from commit f3e7c64)

(cherry picked from commit f9f8c5d)

…TOR (apache#32185)

(cherry picked from commit 06f8f8e)

…e#32195) (cherry picked from commit 0f6bd5e)

(cherry picked from commit eec54af)

…l component (apache#32222) Co-authored-by: Geido <[email protected]> (cherry picked from commit 650fa5c)

…che#32212) (cherry picked from commit d3b854a)

(cherry picked from commit 937d40c)

… is unchecked. (apache#32115) (cherry picked from commit af3589f)

(cherry picked from commit 60424c4)

(cherry picked from commit 31d6f5a)

Co-authored-by: Fardin Mustaque <[email protected]> (cherry picked from commit 52563d3)

(cherry picked from commit 15fbb19)

…ties (apache#32240) (cherry picked from commit ad05732)

…ns (apache#32218) Co-authored-by: Erkka Tahvanainen <[email protected]> (cherry picked from commit 9da3095)

(cherry picked from commit ffe9244)

…che#33422) (cherry picked from commit 21ca26a)

…ache#33364) (cherry picked from commit 29ac507)

(cherry picked from commit dc44748)

(cherry picked from commit b050897)

…he#33522) (cherry picked from commit b4e2406)

Co-authored-by: Amaan Nawab <[email protected]> Co-authored-by: Geido <[email protected]>

… in caret style (apache#30514) (apache#30577) Co-authored-by: garriscp <[email protected]> (cherry picked from commit b7d3ff1)

…sions (apache#33553) (cherry picked from commit 546945e)

Co-authored-by: richardfn <[email protected]> (cherry picked from commit 38868f9)

…#33285) Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 57183da)

(cherry picked from commit ce97597)

(cherry picked from commit b7ba500)

(cherry picked from commit f0b6e87)

(cherry picked from commit 08655a7)

(cherry picked from commit 8decc9e)

…T_NULL operators (apache#33296) (cherry picked from commit cc34608)

…e#33726)

…#33719) (cherry picked from commit 3ef92e5)

(cherry picked from commit a64b9ac)

) (cherry picked from commit 78ad6db)

(cherry picked from commit d7d7b7c)

(cherry picked from commit 8fd0fd6)

(cherry picked from commit 7b6885a)

Co-authored-by: Amaan Nawab <[email protected]>

(cherry picked from commit 775a702)

michael-s-molina and others added 30 commits February 3, 2025 14:07

fix: Histogram examples config (apache#32122)

15c60e8

fix(datepicker): Full width datepicker on filter value select (apache…

95694aa

…#32064) (cherry picked from commit cde2d49)

fix(ci): ephemeral env, handle different label, create comment (apach…

b632567

…e#32040) (cherry picked from commit 0cd0fcd)

fix: No virtual environment when running Docker translation compiler (a…

b80aa86

…pache#32133) (cherry picked from commit 53d944d)

chore: Adds RC1 data to CHANGELOG.md and UPDATING.md

890186a

chore(timeseries charts): adjust legend width by padding (apache#32030)

faae9cc

(cherry picked from commit 8984f88)

fix: Local tarball Docker container is missing zstd dependency (apach…

deb88e4

…e#32135) (cherry picked from commit c64018d)

fix: move oauth2 capture to get_sqla_engine (apache#32137)

92bc43e

(cherry picked from commit c7c3b1b)

fix(releasing): fix borked SVN-based image building process (apache#3…

923d076

…2151) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ea5879b)

fix(migrations): Handle no params in time comparison migration (apach…

e67089b

…e#32155) (cherry picked from commit 6ed9dae)

fix: ScreenshotCachePayload serialization (apache#32156)

50705e7

(cherry picked from commit e8990f4)

fix(docker): Docker python-translation-build (apache#32163)

cbebac9

(cherry picked from commit 5a8488a)

fix(virtual dataset sync): Sync virtual dataset columns when changing…

8ad24fa

… the SQL query (apache#30903) Co-authored-by: Kamil Gabryjelski <[email protected]> (cherry picked from commit f3e7c64)

fix(sqllab): correct URL format for SQL Lab permalinks (apache#32154)

53d05a4

(cherry picked from commit f9f8c5d)

fix: Adds an entry to UPDATING.md about DISABLE_LEGACY_DATASOURCE_EDI…

ed82e6a

…TOR (apache#32185)

fix: TDengine move tdengine.png to databases/ subfolder (apache#32176)

d83ae36

(cherry picked from commit 06f8f8e)

fix: handlebars html and css templates reset on dataset update (apach…

9ea2ad5

…e#32195) (cherry picked from commit 0f6bd5e)

fix: hidrate datasetsStatus (apache#32211)

000f2e3

(cherry picked from commit eec54af)

fix(SaveDatasetModal): repairs field alignment in the SaveDatasetModa…

8ba36ab

…l component (apache#32222) Co-authored-by: Geido <[email protected]> (cherry picked from commit 650fa5c)

fix: set Rich tooltip -> 'Show percentage' to false by default (apa…

699d22c

…che#32212) (cherry picked from commit d3b854a)

fix(sqllab): close the table tab (apache#32224)

8b1de4c

(cherry picked from commit 937d40c)

fix(Scope): Correct issue where filters appear out of scope when sort…

c6e764e

… is unchecked. (apache#32115) (cherry picked from commit af3589f)

chore(ci): fix ephemeral env null issue number (apache#32220)

d0417c3

(cherry picked from commit 60424c4)

chore(ci): fix ephemeral env null issue number (v2) (apache#32221)

6b95ecd

(cherry picked from commit 31d6f5a)

fix: Update 'Last modified' time when modifying RLS rules (apache#32227)

e90b359

Co-authored-by: Fardin Mustaque <[email protected]> (cherry picked from commit 52563d3)

docs: adding notes about using uv instead of raw pip (apache#32239)

adce138

fix: remove sort values on stacked totals (apache#31333)

39859e0

(cherry picked from commit 15fbb19)

fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabili…

4a298e8

…ties (apache#32240) (cherry picked from commit ad05732)

fix(Datasource): handle undefined datasource_type in fetchSyncedColum…

ed217ce

…ns (apache#32218) Co-authored-by: Erkka Tahvanainen <[email protected]> (cherry picked from commit 9da3095)

fix: Decimal values for Histogram bins (apache#32253)

c7cc436

(cherry picked from commit ffe9244)

msyavuz and others added 30 commits May 23, 2025 09:42

fix(Row): don't unload charts while embedded to reduce rerenders (apa…

cd12f30

…che#33422) (cherry picked from commit 21ca26a)

fix(deckgl): fix deckgl multiple layers chart filter and viewport (ap…

6bdfb7a

…ache#33364) (cherry picked from commit 29ac507)

fix(table-chart): time shift is not working (apache#33425)

c54778d

(cherry picked from commit dc44748)

fix: allow metadata to parse json (apache#33444)

ec2b168

(cherry picked from commit b050897)

fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apac…

a86a156

…he#33522) (cherry picked from commit b4e2406)

fix(table): table sort by fix (apache#33540)

405fcfc

Co-authored-by: Amaan Nawab <[email protected]> Co-authored-by: Geido <[email protected]>

fix(user settings): Update forked cosmo theme to resolve down chevron…

979e3a2

… in caret style (apache#30514) (apache#30577) Co-authored-by: garriscp <[email protected]> (cherry picked from commit b7d3ff1)

fix(AllEntities): Display action buttons according to the user permis…

8021a8c

…sions (apache#33553) (cherry picked from commit 546945e)

fix(sankey): incorrect nodeValues (apache#33431)

685b259

Co-authored-by: richardfn <[email protected]> (cherry picked from commit 38868f9)

fix: Adjust viz migrations to also migrate the queries object (apache…

cfba5cd

…#33285) Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 57183da)

fix: Missing processor context when rendering Jinja (apache#33596)

00cd069

(cherry picked from commit ce97597)

fix: Makes time compare migration more resilient (apache#33592)

f9ff325

(cherry picked from commit b7ba500)

chore: Adds RC3 data to CHANGELOG.md

a5f0b24

chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612)

96298a0

(cherry picked from commit f0b6e87)

fix: Migrate charts with empty query_context (apache#33710)

e83ac1d

(cherry picked from commit 08655a7)

feat(api): Added uuid to list api calls (apache#32414)

e5c6d3e

(cherry picked from commit 8decc9e)

fix(template_processing): get_filters now works for IS_NULL and IS_NO…

94369ca

…T_NULL operators (apache#33296) (cherry picked from commit cc34608)

fix(dashboard): show dashboard thumbnail images when retrieved (apach…

77d1849

…e#33726)

fix(Alerts & reports): invalid "Last updated" time formatting (apache…

be13950

…#33719) (cherry picked from commit 3ef92e5)

fix(explore): add gap to the "Cached" button (apache#33717)

24ec0c8

fix(dataset): Fix plural toast messages (apache#33743)

cbbf335

(cherry picked from commit a64b9ac)

fix: sync dot color between dashboard chart and edit chart (apache#33748

715fe6f

) (cherry picked from commit 78ad6db)

fix(create chart page): add missing space between words (apache#33752)

4f1ea35

fix: apply d3 format to BigNumber(s) (apache#33759)

cdbdaf4

(cherry picked from commit d7d7b7c)

fix(tooltip): Sanitize tooltip html (apache#33765)

ad10abd

(cherry picked from commit 8fd0fd6)

build: update Dockerfile to 3.11.13-slim-bookworm (apache#33745)

cff2ce0

(cherry picked from commit 7b6885a)

fix(Echarts): Echarts Legend Scroll fix (apache#33779)

9a6261b

Co-authored-by: Amaan Nawab <[email protected]>

fix: SQL Lab warning message sizes (apache#33817)

f906adb

(cherry picked from commit 775a702)

chore: Adds RC4 data to CHANGELOG.md

465e2a9

fix(table): improve pagination's alignments and add Prev/Next

5fed6f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(table): add Prev/Next and improve pagination paddings #22

fix(table): add Prev/Next and improve pagination paddings #22

Uh oh!

guechhouth commented Oct 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

61 participants

fix(table): add Prev/Next and improve pagination paddings #22

Are you sure you want to change the base?

fix(table): add Prev/Next and improve pagination paddings #22

Uh oh!

Conversation

guechhouth commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

61 participants

guechhouth commented Oct 19, 2025 •

edited

Loading