Feature/dynamic browser tab titles #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#32133) (cherry picked from commit 53d944d)
(cherry picked from commit 8984f88)
(cherry picked from commit c7c3b1b)
…2151) Signed-off-by: hainenber <[email protected]> (cherry picked from commit ea5879b)
(cherry picked from commit e8990f4)
(cherry picked from commit 5a8488a)
… the SQL query (apache#30903) Co-authored-by: Kamil Gabryjelski <[email protected]> (cherry picked from commit f3e7c64)
(cherry picked from commit f9f8c5d)
(cherry picked from commit 06f8f8e)
(cherry picked from commit eec54af)
…l component (apache#32222) Co-authored-by: Geido <[email protected]> (cherry picked from commit 650fa5c)
…che#32212) (cherry picked from commit d3b854a)
(cherry picked from commit 937d40c)
… is unchecked. (apache#32115) (cherry picked from commit af3589f)
(cherry picked from commit 60424c4)
(cherry picked from commit 31d6f5a)
Co-authored-by: Fardin Mustaque <[email protected]> (cherry picked from commit 52563d3)
(cherry picked from commit 15fbb19)
…ties (apache#32240) (cherry picked from commit ad05732)
…ns (apache#32218) Co-authored-by: Erkka Tahvanainen <[email protected]> (cherry picked from commit 9da3095)
(cherry picked from commit ffe9244)
…che#33422) (cherry picked from commit 21ca26a)
…ache#33364) (cherry picked from commit 29ac507)
(cherry picked from commit dc44748)
(cherry picked from commit b050897)
Co-authored-by: Amaan Nawab <[email protected]> Co-authored-by: Geido <[email protected]>
… in caret style (apache#30514) (apache#30577) Co-authored-by: garriscp <[email protected]> (cherry picked from commit b7d3ff1)
…sions (apache#33553) (cherry picked from commit 546945e)
Co-authored-by: richardfn <[email protected]> (cherry picked from commit 38868f9)
…#33285) Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> (cherry picked from commit 57183da)
(cherry picked from commit ce97597)
(cherry picked from commit b7ba500)
(cherry picked from commit f0b6e87)
(cherry picked from commit 08655a7)
(cherry picked from commit 8decc9e)
…T_NULL operators (apache#33296) (cherry picked from commit cc34608)
(cherry picked from commit a64b9ac)
) (cherry picked from commit 78ad6db)
(cherry picked from commit d7d7b7c)
(cherry picked from commit 8fd0fd6)
(cherry picked from commit 7b6885a)
Co-authored-by: Amaan Nawab <[email protected]>
(cherry picked from commit 775a702)
This commit adds dynamic browser tab title management for charts in explore view and enhances the existing dashboard tab title behavior. Changes: - Created useDocumentTitle hook to manage document titles with blur/focus behavior - Updated ExploreViewContainer to set tab title to chart name when viewing charts - Refactored DashboardPage to use the new hook for consistency - Tab title resets to Superset when switching to another browser tab - Tab title restores when returning to the Superset tab - For unsaved charts, displays Superset as the default title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
61 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature(explore): set browser tab title to chart name in explore view
SUMMARY
This pull request adds dynamic browser tab title management for charts in explore view and enhances the existing dashboard tab title behavior with blur/focus functionality.
useDocumentTitlehook that manages document titles with automatic blur/focus behaviorExploreViewContainerto set the browser tab title to the chart name when viewing chartsDashboardPageto use the new hook for consistencyBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
TESTING INSTRUCTIONS
Run Tests:
cd superset-frontendnpm test -- useDocumentTitle.test.tsExpected: All 10 tests pass
TypeScript test:
cd superset-frontendnpm run typeVideo:
https://youtu.be/kqPNHrYvcjc
ADDITIONAL INFORMATION
Fixes: #20