Skip to content

Conversation

@guechhouth
Copy link

SUMMARY

Fixed an issue where SQL Lab query results containing angle brackets were not displayed.
The problem was caused by the isProbablyHTML() function incorrectly treating any string with angle brackets as HTML content.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image
After
image

TESTING INSTRUCTIONS

  1. Open SQL Lab
  2. Run test query:
SELECT '<div>test</div>' as html_string, 
'a<b' as comparison
  1. verify that all the angel bracket are visible

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant