This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Merge CMake modules into one file #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rodburns @DuncanMcBain Discussed this with both of you. Tested and it works fine (on Windows 10 at least), not much has really changed, the files are just combined into the one. |
DuncanMcBain
approved these changes
Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, both CMake files are required for the CMake to run and are simply included within the main FindComputeCpp.cmake file. I have simply removed the files and moved their contents in place of their respective CMake includes. This shouldn't hinder readability as both files are short and the main file is 500+ lines anyway. Combining the files also makes it easier for users to utilize the single file in setting up CMake projects.