This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Fix INTERFACE->PUBLIC in compile definitions #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only targets which subsequently linked against targets which had the SYCL version set as a compile definition would see it. Now, since it is PUBLIC, all targets which link and the target itself will see the definition of the language version.
Rbiessy
approved these changes
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only targets which subsequently linked against targets
which had the SYCL version set as a compile definition would see
it. Now, since it is PUBLIC, all targets which link and the target
itself will see the definition of the language version.