Update PVC drivers #391
Update PVC drivers #391
Conversation
Co-authored-by: carlewis <carlewis@gmail.com>
Co-authored-by: carlewis <carlewis@gmail.com>
Co-authored-by: carlewis <carlewis@gmail.com>
| @@ -16,7 +16,7 @@ inputs: | |||
| description: "Install for PVC or BMG gpu" | |||
| type: string | |||
| IGC: | |||
| description: "Use RELEASE of STAGING release" | |||
| description: "Use ROLLING of STAGING release" | |||
There was a problem hiding this comment.
Is this supposed to say:
| description: "Use ROLLING of STAGING release" | |
| description: "Use ROLLING or STAGING release" |
| using: "composite" | ||
| steps: | ||
| - name: Install Intel graphics drivers | ||
| if: inputs.IGC == 'ROLLING' |
There was a problem hiding this comment.
Why do you call this rolling? I haven't seen anyone else refer to this version under that name. And https://dgpu-docs.intel.com/driver/installation.html does have the name rolling, therefore this might be confusing.
I would suggest as names: kobuk and kobuk-staging.
There was a problem hiding this comment.
I think kobuk is only valid for client GPU. I'm using rolling because it is the name used in https://dgpu-docs.intel.com/driver/installation.html and in https://dgpu-docs.intel.com/driver/client/overview.html
"This document explains how to choose the appropriate version of Ubuntu Desktop for your client GPU and install the necessary drivers from the latest rolling release."
# Conflicts: # .github/actions/install-dpcpp/action.yml
This PR updates the intel graphics drivers for PVC