Skip to content

perf: add DirectEncoder to eliminate nested MarshalJSON allocation chain #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstcn merged 9 commits into from
Apr 15, 2026
Merged

perf: add DirectEncoder to eliminate nested MarshalJSON allocation chain #7

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5a3042
bench: add marshal allocation benchmark for the quadratic memory inqu…
johnstcn Apr 15, 2026
3733d64
test: skip tests that require mock server or VCR cassettes
johnstcn Apr 15, 2026
47ce0eb
perf: add DirectEncoder interface to bypass MarshalJSON allocation chain
johnstcn Apr 15, 2026
5ff81d3
refactor: add exported IsNull() to avoid param.IsNull alloc overhead
johnstcn Apr 15, 2026
2871442
perf: add DirectEncoder to all 22 union types
johnstcn Apr 15, 2026
394c240
test: gate skips on env vars instead of unconditional t.Skip
johnstcn Apr 15, 2026
342eb8c
perf: add EncodeDirect to all 102 MarshalJSON types with coverage test
johnstcn Apr 15, 2026
3a31df9
perf: add EncodeDirect to all 246 types, AST-based coverage test
johnstcn Apr 15, 2026
678f2e9
bench: exercise all ContentBlockParamUnion variants in marshal benchmark
johnstcn Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions betafile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
)

func TestBetaFileListWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -45,6 +46,7 @@ func TestBetaFileListWithOptionalParams(t *testing.T) {
}

func TestBetaFileDeleteWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -113,6 +115,7 @@ func TestBetaFileDownloadWithOptionalParams(t *testing.T) {
}

func TestBetaFileGetMetadataWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Comment thread
johnstcn marked this conversation as resolved.
Outdated
Expand Down Expand Up @@ -141,6 +144,7 @@ func TestBetaFileGetMetadataWithOptionalParams(t *testing.T) {
}

func TestBetaFileUploadWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down
2 changes: 2 additions & 0 deletions betamessage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
)

func TestBetaMessageNewWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
t.Skip("prism validates based on the non-beta endpoint")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
Expand Down Expand Up @@ -177,6 +178,7 @@ func TestBetaMessageNewWithOptionalParams(t *testing.T) {
}

func TestBetaMessageCountTokensWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
t.Skip("prism validates based on the non-beta endpoint")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
Expand Down
5 changes: 5 additions & 0 deletions betamessagebatch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
)

func TestBetaMessageBatchNewWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
t.Skip("prism validates based on the non-beta endpoint")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
Expand Down Expand Up @@ -182,6 +183,7 @@ func TestBetaMessageBatchNewWithOptionalParams(t *testing.T) {
}

func TestBetaMessageBatchGetWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -210,6 +212,7 @@ func TestBetaMessageBatchGetWithOptionalParams(t *testing.T) {
}

func TestBetaMessageBatchListWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -237,6 +240,7 @@ func TestBetaMessageBatchListWithOptionalParams(t *testing.T) {
}

func TestBetaMessageBatchDeleteWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -265,6 +269,7 @@ func TestBetaMessageBatchDeleteWithOptionalParams(t *testing.T) {
}

func TestBetaMessageBatchCancelWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down
2 changes: 2 additions & 0 deletions betamodel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
)

func TestBetaModelGetWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -42,6 +43,7 @@ func TestBetaModelGetWithOptionalParams(t *testing.T) {
}

func TestBetaModelListWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down
4 changes: 4 additions & 0 deletions betaskill_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
)

func TestBetaSkillNewWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
t.Skip("prism binary unsupported")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
Expand Down Expand Up @@ -43,6 +44,7 @@ func TestBetaSkillNewWithOptionalParams(t *testing.T) {
}

func TestBetaSkillGetWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -71,6 +73,7 @@ func TestBetaSkillGetWithOptionalParams(t *testing.T) {
}

func TestBetaSkillListWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -98,6 +101,7 @@ func TestBetaSkillListWithOptionalParams(t *testing.T) {
}

func TestBetaSkillDeleteWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down
4 changes: 4 additions & 0 deletions betaskillversion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
)

func TestBetaSkillVersionNewWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
t.Skip("prism binary unsupported")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
Expand Down Expand Up @@ -46,6 +47,7 @@ func TestBetaSkillVersionNewWithOptionalParams(t *testing.T) {
}

func TestBetaSkillVersionGetWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -75,6 +77,7 @@ func TestBetaSkillVersionGetWithOptionalParams(t *testing.T) {
}

func TestBetaSkillVersionListWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down Expand Up @@ -105,6 +108,7 @@ func TestBetaSkillVersionListWithOptionalParams(t *testing.T) {
}

func TestBetaSkillVersionDeleteWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
Comment thread
johnstcn marked this conversation as resolved.
Outdated
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Expand Down
1 change: 1 addition & 0 deletions completion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
)

func TestCompletionNewWithOptionalParams(t *testing.T) {
t.Skip("requires mock server on localhost:4010")
baseURL := "http://localhost:4010"
if envURL, ok := os.LookupEnv("TEST_API_BASE_URL"); ok {
baseURL = envURL
Comment thread
johnstcn marked this conversation as resolved.
Outdated
Expand Down
48 changes: 48 additions & 0 deletions direct_encoder_compat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package anthropic_test

import (
"bytes"
"encoding/json"
"fmt"
"testing"
)

func TestMarshalMessageNewParams_ByteIdentical(t *testing.T) {
// Build conversations of various sizes.
for _, numPairs := range []int{1, 10, 50} {
t.Run(fmt.Sprintf("pairs=%d", numPairs), func(t *testing.T) {
params := buildConversation(numPairs)

// Marshal twice — output must be deterministic and identical.
first, err := json.Marshal(params)
if err != nil {
t.Fatal(err)
}
second, err := json.Marshal(params)
if err != nil {
t.Fatal(err)
}
if !bytes.Equal(first, second) {
t.Fatal("Marshal output is not deterministic")
}

// Verify output is valid JSON.
var raw json.RawMessage
if err := json.Unmarshal(first, &raw); err != nil {
t.Fatalf("Marshal output is not valid JSON: %v", err)
}

// Verify key structure exists.
var parsed map[string]json.RawMessage
if err := json.Unmarshal(first, &parsed); err != nil {
t.Fatal(err)
}
if _, ok := parsed["messages"]; !ok {
t.Fatal("missing 'messages' key in output")
}
if _, ok := parsed["model"]; !ok {
t.Fatal("missing 'model' key in output")
}
})
}
}
Loading
Loading