feat: add persistent terminal module #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new Terminal component for embedding a terminal interface within the application. - Added corresponding styles in Terminal.scss to ensure proper layout and appearance. - Updated index.ts to export the Terminal component for accessibility within the module.
- Updated renderCustomEmbeddable function to include support for the new Terminal component. - Added case handling for 'terminal' to render the Terminal interface when the corresponding link is detected. - Enhanced user experience by providing additional embedding options within the application.
- Integrated a new Terminal item in the Main Menu for user access. - Implemented handleTerminalClick function to create and place a terminal element in the canvas. - Enhanced user experience by providing direct access to terminal functionality within the application.
- Added state management for terminal ID and connection info within the Terminal component. - Implemented UUID generation for unique terminal identification. - Updated customData handling to store and retrieve terminal connection information. - Improved terminal URL generation logic to include reconnect parameters based on terminal ID. - Enhanced initialization logic to ensure proper setup of terminal connection data.
- Renamed getUrl to getCodeUrl for clarity. - Simplified URL generation logic for terminal and code targets. - Consolidated embedding logic by directly using ExcalidrawElementFactory for creating embeddable elements. - Improved error handling for URL determination in both embedding and opening actions. - Enhanced debug logging for better traceability of actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor the existing Terminal feature into its own component and exposes it as a module on pad.ws as !terminal:
This also makes them persistent.