feat: implement runtime config loading for frontend #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified AuthGate component to retrieve Coder URL from environment variable instead of hardcoding. - Added new CODER_URL definition in env.d.ts for better configuration management.
- Updated vite.config.mts to load environment variables based on the current mode, allowing for better configuration management. - Made CODER_URL available through import.meta.env for improved flexibility in accessing environment-specific settings.
- Changed the environment variable reference in AuthGate from VITE_CODER_URL to CODER_URL for consistency with the updated configuration management.
…itialization - Modified Dockerfile to copy and execute a new startup script instead of directly running the application. - Introduced startup.sh to create a runtime configuration file with environment variables and start the application. - Updated index.html to include the new runtime configuration script. - Enhanced AuthGate component to utilize the runtime configuration for the Coder URL, providing fallback to environment variables. - Added global TypeScript definitions for the runtime configuration interface.
…ence - Changed the directory for the runtime configuration file from /config to /assets in startup.sh. - Updated index.html to reference the new location of the runtime configuration script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where we had no way to read from the
.envand pass a value to the built frontend.This workaround creates a file at container runtime that will provide non-confidential environment variables to the frontend, that it can then use in turn, to match the user specific config.
This is also a fix for #51 which didn't work properly as the frontend didn't have access to the variables it needed.