feat: hand tool locks embeds #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated LockIndicator to accept appState as a prop, allowing it to respond to hand tool activation. - Improved visibility logic for the lock icon based on scrolling and hand tool state. - Added new styles for lock icon text in CustomEmbeddableRenderer.scss to enhance user feedback during interactions.
- Updated LockIndicator component to conditionally render the Hand tool text based on the isHandToolActive state, enhancing user feedback during interactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This locks embeds while Hand tool is selected as well as indicates it next to the lock.
This should help mobile users to navigate and put the focus on "moving around" with Hand tool whereas "cursor" tool should focus on clicking/selecting.