Skip to content

feat/add-page-titles-for-browser-tabs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pirasan023 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat/add-page-titles-for-browser-tabs #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f3edc9
全てのページでブラウザのタブに適切な名前が出るように
pirasan023 Feb 8, 2026
5301bfa
見逃していた
pirasan023 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---
permalink: /404.html
layout: default
hero_title: "ページが見つかりません"
hero_subtitle: "404 Not Found"
title: "ページが見つかりません"
subtitle: "404 Not Found"
---

<!-- TODO: include navbar.html -->

<div class="text-center my-40 mx-8 xl:my-20">
<h2 class="text-5xl">Page Not Found</h1>
<h2 class="text-5xl">Page Not Found</h2>

<p class="my-8">
<strong>お探しのページが見つかりませんでした🥹</strong><br />
Expand Down
4 changes: 2 additions & 2 deletions _archives/apply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "応募"
hero_subtitle: "APPLY"
title: "応募"
subtitle: "APPLY"
permalink: /apply/
---

Expand Down
4 changes: 2 additions & 2 deletions _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<main class="flex-grow">
<header class="hero">
<div class="hero-container">
<h1 class="hero-title">{{ page.hero_title }}</h1>
<p class="hero-subtitle">{{ page.hero_subtitle }}</p>
<h1 class="hero-title">{{ page.hero_title | default: page.title }}</h1>
<p class="hero-subtitle">{{ page.hero_subtitle | default: page.subtitle }}</p>
Comment on lines +10 to +11
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is migrating pages to title/subtitle, the fallback order here should prefer the new keys first to avoid mismatches when both old and new front-matter fields are present. Consider switching to page.title | default: page.hero_title and page.subtitle | default: page.hero_subtitle.

Suggested change
<h1 class="hero-title">{{ page.hero_title | default: page.title }}</h1>
<p class="hero-subtitle">{{ page.hero_subtitle | default: page.subtitle }}</p>
<h1 class="hero-title">{{ page.title | default: page.hero_title }}</h1>
<p class="hero-subtitle">{{ page.subtitle | default: page.hero_subtitle }}</p>

Copilot uses AI. Check for mistakes.
</div>
</header>
{{ content }}
Expand Down
4 changes: 2 additions & 2 deletions about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "開催概要"
hero_subtitle: "ABOUT"
title: "開催概要"
subtitle: "ABOUT"
---

<!-- コンテンツエリア -->
Expand Down
4 changes: 2 additions & 2 deletions conduct.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "行動規範"
hero_subtitle: "Code of Conduct"
title: "行動規範"
subtitle: "Code of Conduct"
---

<!-- コンテンツエリア -->
Expand Down
4 changes: 2 additions & 2 deletions contact.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "お問い合わせ"
hero_subtitle: "CONTACT"
title: "お問い合わせ"
subtitle: "CONTACT"
---

<!-- コンテンツエリア -->
Expand Down
4 changes: 2 additions & 2 deletions display-rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "展示のおやくそく"
hero_subtitle: "DISPLAY RULES"
title: "展示のおやくそく"
subtitle: "DISPLAY RULES"
---

<!-- コンテンツエリア -->
Expand Down
4 changes: 2 additions & 2 deletions events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "来場応募"
hero_subtitle: "EVENTS"
title: "来場応募"
subtitle: "EVENTS"
---

<div class="bg-white py-16 px-4">
Expand Down
4 changes: 2 additions & 2 deletions news.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "お知らせ"
hero_subtitle: "NEWS"
title: "お知らせ"
subtitle: "NEWS"
---

<div class="bg-white py-16 px-4">
Expand Down
4 changes: 2 additions & 2 deletions privacy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "プライバシーポリシー"
hero_subtitle: "PRIVACY POLICY"
title: "プライバシーポリシー"
subtitle: "PRIVACY POLICY"
redirect_from:
- /privacy-policy/
---
Expand Down
4 changes: 2 additions & 2 deletions register.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "来場応募する"
hero_subtitle: "Registration"
title: "来場応募する"
subtitle: "Registration"
redirect_from:
- /registration/
---
Expand Down
17 changes: 17 additions & 0 deletions sponsor-smartone.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
layout: default
title: "株式会社SmartOne"
subtitle: "Gold Sponsor"
---
Comment on lines +1 to +5
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description only mentions renaming hero_title/hero_subtitle to title/subtitle, but this PR also adds a new sponsor page. Please either update the PR description to include this new page (and intended URL/linking), or move it to a separate PR to keep the change focused.

Copilot uses AI. Check for mistakes.

<img src="/img/contests/sponsor-logos/smartone.svg" alt="SmartOne-Logo" class="pt-12 pb-12 mx-auto mb-8 max-h-100">
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-h-100 is not defined in the repo’s CSS and isn’t a standard Tailwind utility, so this class will have no effect and the sponsor logo may render at an unintended size. Use a valid Tailwind class (e.g., max-h-24/max-h-32) or an arbitrary value (max-h-[100px]), or add a corresponding CSS rule.

Suggested change
<img src="/img/contests/sponsor-logos/smartone.svg" alt="SmartOne-Logo" class="pt-12 pb-12 mx-auto mb-8 max-h-100">
<img src="/img/contests/sponsor-logos/smartone.svg" alt="SmartOne-Logo" class="pt-12 pb-12 mx-auto mb-8 max-h-[100px]">

Copilot uses AI. Check for mistakes.

<a class="button-push block mx-auto w-fit my-8" href="https://cafe-bar.starrobox.com/" target="_blank" rel="noopener noreferrer">公式ホームページを見る</a>

<div class="md-container">
<div class="md-body">
株式会社SmartOneは、ロボットによる自動化・開発、CADスクール運営、そしてロボットショールームとして「ロボットカフェバー」を運営しています。
<br>最新ロボット技術を体験できる場を提供し、未来の技術者育成と地域振興に貢献します。
<br>子どもたちの夢と挑戦を支援し、地域の未来を共に創造していきたいと考えています。
</div>
</div>
4 changes: 2 additions & 2 deletions sponsors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "スポンサー"
hero_subtitle: "COOLEST PARTNERS"
title: "スポンサー"
subtitle: "COOLEST PARTNERS"
---

<!-- コンテンツエリア -->
Expand Down
4 changes: 2 additions & 2 deletions staff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "運営に参加する"
hero_subtitle: "join us"
title: "運営に参加する"
subtitle: "join us"
---

<div class="bg-white py-16 px-4">
Expand Down
4 changes: 2 additions & 2 deletions travel-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
layout: default
hero_title: "交通費補助"
hero_subtitle: "TRAVEL SUPPORT"
title: "交通費補助"
subtitle: "TRAVEL SUPPORT"
---

<!-- コンテンツエリア -->
Expand Down