chore: prework for npm publish #134
Conversation
|
Thanks for helping get this started :) |
Rakefile
Outdated
| @@ -54,6 +54,11 @@ namespace :shipyard do | |||
| end | |||
| end | |||
|
|
|||
| desc 'Publish project to npm as scoped package @codeship/shipyard' | |||
| task :console do | |||
| sh 'npm publish --access public' | |||
There was a problem hiding this comment.
Are the files builded by then (e.g. sass 2 css)?
There was a problem hiding this comment.
They can be. The sass files will always be ready to go, but the css would need to be compiled first, yes.
There was a problem hiding this comment.
To be clear though, there's no requirement that the CSS is packaged as the best way to consume all of this will be through the sass files anyways.
There was a problem hiding this comment.
Let's start with sass. For some playground or prototyping it would be useful to have compiled versions, but we don't have a use-case for that ATM.
Rakefile
Outdated
| @@ -54,6 +54,11 @@ namespace :shipyard do | |||
| end | |||
| end | |||
|
|
|||
| desc 'Publish project to npm as scoped package @codeship/shipyard' | |||
| task :console do | |||
| sh 'npm publish --access public' | |||
There was a problem hiding this comment.
Imo that needs to be the last part of the rakefile.
Rakefile
Outdated
|
|
||
| desc 'Publish project to npm as a scoped package @codeship/shipyard' | ||
| task :console do | ||
| sh 'npm publish --access public' |
There was a problem hiding this comment.
Two questions:
- Does this need to authenticate with anything?
- Do we need to add this command to the CI
deploystage?
| set -e # halt script on error | ||
|
|
||
| echo -e "\n\n************** NPM publish for @codeship/shipyard **************" | ||
| npm publish --access public |
There was a problem hiding this comment.
Apologies, I misunderstood the build system,
this should be called as a step on master branch - same as other scripts.
There was a problem hiding this comment.
@codebryo @ryanjwilke
Do we need to authenticate against NPM or is that configured automatically for the build? How are you doing that for other NPM codeship packages - which have scoped package @codeship
There was a problem hiding this comment.
I would assume that would be injected as environment variables from the pipeline configuration.
| @@ -42,3 +42,7 @@ | |||
| service: shipyard | |||
| name: GitHub Pages | |||
| command: ./ci/github | |||
| - | |||
There was a problem hiding this comment.
Will be executed only on master branch.
No description provided.