Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades cosmic-text to version 0.14.2 and adapts the code to work with the new API. The key changes include updating imports and font loading in text.rs, refactoring attribute handling in text measurement and rich text, and adjusting font style handling in highlight.rs.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/utils/text.rs | Updated imports, new font constants, and usage of a default attribute helper function to align with cosmic-text 0.14.2 API. |
| core/src/utils/highlight.rs | Introduced cloning of attributes to avoid mutation when applying different font styles. |
| core/Cargo.toml | Upgraded the cosmic-text dependency version from 0.12.0 to 0.14.2. |
Comments suppressed due to low confidence (1)
core/src/utils/text.rs:25
- Verify that the family name string 'CaskaydiaCove Nerd Font' matches the expected naming convention used in the font asset filenames (e.g., 'CaskaydiaCoveNerdFont').
Attrs::new().family(Family::Name("CaskaydiaCove Nerd Font"))
| .into_iter() | ||
| .map(|(style, str)| { | ||
| let syntect::highlighting::Color { r, g, b, a } = style.foreground; | ||
| let attrs_cloned = attrs.clone(); |
There was a problem hiding this comment.
[nitpick] Consider whether cloning 'attrs' on every iteration might introduce a slight performance overhead; if 'attrs' remains constant, reusing a previously cloned value could be more efficient.
Suggested change
| let attrs_cloned = attrs.clone(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.