fix(link-tool): open new window with url when formatted link clicked via ctrl key#2996
Merged
fix(link-tool): open new window with url when formatted link clicked via ctrl key#2996
Conversation
akulistus
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
neSpecc
reviewed
Mar 11, 2026
akulistus
commented
Mar 11, 2026
Co-authored-by: Peter <specc.dev@gmail.com> Co-authored-by: KoshaevEugeny <103786108+akulistus@users.noreply.github.com>
neSpecc
reviewed
Mar 11, 2026
| .should('contain', 'Bold and italic text'); | ||
| }); | ||
|
|
||
| it('should open formatted link in the same tab', () => { |
Member
There was a problem hiding this comment.
test name is not clearly describes the case you just fixed
neSpecc
reviewed
Mar 11, 2026
Co-authored-by: Peter <specc.dev@gmail.com>
neSpecc
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When clicking a formatted link, inline elements (e.g., bold, italic) may be returned as the event target instead of the anchor element. As a result, the expected link behavior is not triggered.
Issue:
#2995
Solution:
Check whether the event target has an anchor () element among its ancestors and use that element to process the link action.