Fix unlink functionality in inline tools#2998
Open
AlexGaillard wants to merge 1 commit intocodex-team:nextfrom
Open
Fix unlink functionality in inline tools#2998AlexGaillard wants to merge 1 commit intocodex-team:nextfrom
AlexGaillard wants to merge 1 commit intocodex-team:nextfrom
Conversation
AlexGaillard
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
Contributor
|
Hi! Also, could you add a test case that verifies the unlink behavior when clicking an inline item? Additionally, please include a changelog entry and bump the version. I'll check out the solution in more detail later and ask neSpecc to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the issue preventing users from unlinking elements in the inline tools. Adjustments ensure proper handling of input elements and selection restoration.
Also improves the unlinking behavior from how it was before #2979 broke it (doesn't require multiple clicks) 😓
Screen.Recording.2026-03-12.at.4.56.26.PM.mov