fix(accounts): replace plans $lookup with in-memory join#161
Open
Kuchizu wants to merge 2 commits into
Open
Conversation
neSpecc
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the accounts limits cache refresh logic to avoid a MongoDB $lookup from workspaces into plans (which inflated plan read-time metrics) by fetching plans once and joining them to workspaces in memory before applying workspace/project overrides.
Changes:
- Replaces the workspaces→plans aggregation
$lookup/$unwindwith separateFind()calls and an in-memory join via aplansMap. - Updates the workspace model used by the cache refresh to store
tariffPlanIdinstead of an embeddedplan. - Adjusts the limits resolution logic to read plan limits from the joined plan entry while preserving existing override precedence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+95
to
+101
| // Join plans in memory: $lookup would read plans once per workspace doc | ||
| plansCollection := client.mdb.Database(client.database).Collection(plansCollectionName) | ||
| plansCursor, err := plansCollection.Find(ctx, bson.D{}) | ||
| if err != nil { | ||
| log.Errorf("Cannot create cursor in %s collection for cache update: %s", plansCollectionName, err) | ||
| return err | ||
| } |
Member
Author
There was a problem hiding this comment.
No plans is a tiny static collection.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace plans $lookup with in-memory join in limits cache update.
$lookup from workspaces into plans issued one inner read of plans per workspace on every cache refresh, inflating its read-time metric. Fetch plans with a single find and join in memory instead. Resulting limits are unchanged.