Skip to content

imp(source-maps): do not send minified source cod frames #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
e11sy merged 2 commits into from
Mar 8, 2025
Merged

imp(source-maps): do not send minified source cod frames #114

e11sy merged 2 commits into from
Mar 8, 2025

Conversation

@e11sy
Copy link
Contributor

@e11sy e11sy commented Mar 8, 2025

Problem

  • Now if error happened in minified code, but in column < 200, source could would be send with stack trace

Solution

  • Check all lines to be sent as source code to have length less than 200, otherwise treat them as a minified code

neSpecc
neSpecc reviewed Mar 8, 2025
View reviewed changes
src/modules/stackParser.ts Outdated
* For this cases we need to check, that all of the lines to collect have length less than 200 too
*/
for (const lineToCheck in lines.slice(lineFrom, lineTo)) {
if (lineToCheck.length > 200) {
Copy link
Member

@neSpecc neSpecc Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move 200 to a contstant

@e11sy e11sy requested a review from neSpecc March 8, 2025 14:57
@e11sy e11sy merged commit 1d3971f into master Mar 8, 2025
2 checks passed
@e11sy e11sy deleted the improve-source-code-sending branch March 8, 2025 15:52
@e11sy e11sy mentioned this pull request Mar 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e11sy @neSpecc