Clean up remaining code for dropped Django versions#407
Merged
codingjoe merged 4 commits intocodingjoe:masterfrom Jun 9, 2025
Merged
Clean up remaining code for dropped Django versions#407codingjoe merged 4 commits intocodingjoe:masterfrom
codingjoe merged 4 commits intocodingjoe:masterfrom
Conversation
Closed
Collaborator
|
Going to talk with Frank about this and then i'll circle back! |
KOliver94
force-pushed
the
drop-eol
branch
2 times, most recently
from
57dd2c5 to
ca89b41
Compare
Contributor
Author
|
Hi @codingjoe, Although #463 removed support for EOL Django and Python versions, there are still several parts of the codebase that include compatibility for them. I've updated my earlier PR to fully drop support for Django versions older than 4.2 as well. |
KOliver94
changed the title
codingjoe
approved these changes
Jun 9, 2025
Owner
There was a problem hiding this comment.
Hi @KOliver94,
Excellent! I appreciate the support. I wanted to get the packaging update out of the door without any changes to the code. With that out of the way, it's high time to drop the legacy code.
I added a commit where I used django-upgrade to spot a few other legacy lines.
Thanks again!
Joe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #397 is conflicting I'm splitting it into 2 new PRs. In this one I'm removing all no more officially supported Django versions.