Skip to content

Disable atomic requests for health-check view#469

Merged
codingjoe merged 4 commits intocodingjoe:masterfrom
TheSuperiorStanislav:feature/disable-atomic-requests-for-health-check
Dec 19, 2025
Merged

Disable atomic requests for health-check view#469
codingjoe merged 4 commits intocodingjoe:masterfrom
TheSuperiorStanislav:feature/disable-atomic-requests-for-health-check

Conversation

@TheSuperiorStanislav
Copy link
Copy Markdown
Contributor

@TheSuperiorStanislav TheSuperiorStanislav commented Jun 10, 2025

Disable atomic requests, because when ATOMIC_REQUEST=True django would
still go to db to check the state, meaning there would an error when db is
not available, which would result in django error 500 page rather than
HealthCheck 500 response.

Note: these endpoints are still dependant on db, if you logged in via
browser, or in other words have session cookies.

@TheSuperiorStanislav TheSuperiorStanislav marked this pull request as ready for review June 10, 2025 01:06
@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/disable-atomic-requests-for-health-check branch from 92aebad to 8b335b5 Compare June 11, 2025 09:15
@codingjoe codingjoe added the bug label Dec 19, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.83%. Comparing base (1807ffe) to head (b133384).
⚠️ Report is 103 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   76.92%   85.83%   +8.90%     
==========================================
  Files          40       61      +21     
  Lines         533     1941    +1408     
  Branches      110        0     -110     
==========================================
+ Hits          410     1666    +1256     
- Misses        115      275     +160     
+ Partials        8        0       -8     
Flag Coverage Δ
python-3.10-django-4.2 86.51% <100.00%> (?)
python-3.10-django-5.2 96.27% <100.00%> (?)
python-3.11-django-4.2 86.51% <100.00%> (?)
python-3.11-django-5.2 96.27% <100.00%> (?)
python-3.12-django-4.2 86.51% <100.00%> (?)
python-3.12-django-5.2 86.30% <100.00%> (?)
python-3.13-django-4.2 86.51% <100.00%> (?)
python-3.13-django-5.2 86.30% <100.00%> (?)
python-3.9-django-4.2 96.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheSuperiorStanislav 👋,

Thank you for your contribution. I took a look into it, and it didn't work for me just yet. I added a regression test and fixed the implementation.

Furthermore, I will drop the docstring. Documentation is good, but this is rather use case specific, and the behavior is now tested.

Cheers!
Joe

@codingjoe codingjoe merged commit 7b93658 into codingjoe:master Dec 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants