Disable atomic requests for health-check view#469
Conversation
92aebad to
8b335b5
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 76.92% 85.83% +8.90%
==========================================
Files 40 61 +21
Lines 533 1941 +1408
Branches 110 0 -110
==========================================
+ Hits 410 1666 +1256
- Misses 115 275 +160
+ Partials 8 0 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codingjoe
left a comment
There was a problem hiding this comment.
Hi @TheSuperiorStanislav 👋,
Thank you for your contribution. I took a look into it, and it didn't work for me just yet. I added a regression test and fixed the implementation.
Furthermore, I will drop the docstring. Documentation is good, but this is rather use case specific, and the behavior is now tested.
Cheers!
Joe
Disable atomic requests, because when
ATOMIC_REQUEST=Truedjango wouldstill go to db to check the state, meaning there would an error when db is
not available, which would result in django error 500 page rather than
HealthCheck 500 response.
Note: these endpoints are still dependant on db, if you logged in via
browser, or in other words have session cookies.