Skip to content

Fix #659 - Add port to distinguish redis instances#670

Merged
codingjoe merged 2 commits intocodingjoe:mainfrom
gabriele-v:main
Mar 4, 2026
Merged

Fix #659 - Add port to distinguish redis instances#670
codingjoe merged 2 commits intocodingjoe:mainfrom
gabriele-v:main

Conversation

@gabriele-v
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 26, 2026 21:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Redis health check’s string representation so multiple Redis instances can be distinguished when they differ by port (per “Fixes #659”).

Changes:

  • Include port alongside host and db in the Redis health check __repr__ connection details.

Comment thread health_check/contrib/redis.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.74%. Comparing base (07c5eaa) to head (3f1b17a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   99.73%   99.74%           
=======================================
  Files          13       13           
  Lines         763      772    +9     
=======================================
+ Hits          761      770    +9     
  Misses          2        2           
Flag Coverage Δ
python-3.10-django-5.2 50.38% <ø> (-0.34%) ⬇️
python-3.10-django-5.2-celery 55.18% <ø> (-0.39%) ⬇️
python-3.10-django-5.2-kafka 53.36% <ø> (-0.37%) ⬇️
python-3.10-django-5.2-psutil 61.78% <ø> (-0.47%) ⬇️
python-3.10-django-5.2-rabbitmq 53.10% <ø> (-0.37%) ⬇️
python-3.10-django-5.2-redis 56.60% <ø> (-0.41%) ⬇️
python-3.10-django-5.2-rss 70.07% <ø> (+0.35%) ⬆️
python-3.11-django-5.2 50.38% <ø> (-0.34%) ⬇️
python-3.12-django-5.2 50.38% <ø> (-0.34%) ⬇️
python-3.12-django-6.0 50.38% <ø> (-0.34%) ⬇️
python-3.13-django-5.2 50.38% <ø> (-0.34%) ⬇️
python-3.13-django-6.0 50.38% <ø> (-0.34%) ⬇️
python-3.14-django-5.2 50.65% <ø> (-0.34%) ⬇️
python-3.14-django-5.2-celery 55.46% <ø> (-0.40%) ⬇️
python-3.14-django-5.2-kafka 53.51% <ø> (-0.38%) ⬇️
python-3.14-django-5.2-psutil 62.10% <ø> (-0.48%) ⬇️
python-3.14-django-5.2-rabbitmq 53.25% <ø> (-0.37%) ⬇️
python-3.14-django-5.2-redis 56.90% <ø> (-0.42%) ⬇️
python-3.14-django-5.2-rss 71.09% <ø> (+0.34%) ⬆️
python-3.14-django-6.0 50.65% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@codingjoe codingjoe changed the title Fixes #659 - Add port to distinguish redis instances Fix #659 - Add port to distinguish redis instances Mar 4, 2026
@codingjoe codingjoe linked an issue Mar 4, 2026 that may be closed by this pull request
@codingjoe codingjoe merged commit 4b29585 into codingjoe:main Mar 4, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add label to Redis check

3 participants