Update ADK configuration and add local Docker testing setup#17
Conversation
- Also add .dockerignore to prevent local dev file entering image
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the development and testing process by updating the ADK application's naming convention and introducing a comprehensive local Docker setup. These changes aim to provide a more consistent and isolated environment for developers, making it easier to build, run, and test the application locally, mirroring the CI/CD pipeline. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a local Docker testing setup using Docker Compose, which is a significant improvement for the development workflow. It also refactors the ADK application name from cofacts-ai to cofacts_ai for consistency with Python package naming conventions, and updates the ADK server command. The changes are well-implemented. I have a couple of minor suggestions to improve the documentation and the new Docker Compose configuration for consistency.

Summary
This PR bundles several improvements to the local development experience and ADK integration.
✅ Add
docker-compose.ymlfor local buildsAdds a
docker-compose.ymlthat builds both services from source and wires them together, making it easy to spin up the full stack locally and validate the Docker build before deployment:frontend— builds from the rootDockerfile, exposed on port 3000, configured withADK_URLpointing to the backend servicebackend— builds fromadk/Dockerfile, exposed on port 8000, reads secrets fromadk/cofacts_ai/.envviaenv_file, and includes a health check so the frontend only starts once ADK is ready🐛 Fix ADK app name (underscore vs. hyphen)
ADK requires the app name to match the Python module directory name, which uses underscores. Changed
cofacts-ai→cofacts_aiin:src/lib/adk.tssrc/routes/api/sessions.tssrc/routes/api/sessions.$sessionId.ts📦 Upgrade
google-adk(lockfile update)Updated
adk/uv.lockto pull in the latestgoogle-adkand its transitive dependencies.