Skip to content

Update ADK configuration and add local Docker testing setup#17

Merged
MrOrz merged 5 commits into
masterfrom
upgrade-adk
Mar 13, 2026
Merged

Update ADK configuration and add local Docker testing setup#17
MrOrz merged 5 commits into
masterfrom
upgrade-adk

Conversation

@MrOrz
Copy link
Copy Markdown
Member

@MrOrz MrOrz commented Mar 12, 2026

Summary

This PR bundles several improvements to the local development experience and ADK integration.

✅ Add docker-compose.yml for local builds

Adds a docker-compose.yml that builds both services from source and wires them together, making it easy to spin up the full stack locally and validate the Docker build before deployment:

  • frontend — builds from the root Dockerfile, exposed on port 3000, configured with ADK_URL pointing to the backend service
  • backend — builds from adk/Dockerfile, exposed on port 8000, reads secrets from adk/cofacts_ai/.env via env_file, and includes a health check so the frontend only starts once ADK is ready

🐛 Fix ADK app name (underscore vs. hyphen)

ADK requires the app name to match the Python module directory name, which uses underscores. Changed cofacts-aicofacts_ai in:

  • src/lib/adk.ts
  • src/routes/api/sessions.ts
  • src/routes/api/sessions.$sessionId.ts

📦 Upgrade google-adk (lockfile update)

Updated adk/uv.lock to pull in the latest google-adk and its transitive dependencies.

@github-actions github-actions Bot temporarily deployed to pr-17 March 12, 2026 07:58 Destroyed
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the development and testing process by updating the ADK application's naming convention and introducing a comprehensive local Docker setup. These changes aim to provide a more consistent and isolated environment for developers, making it easier to build, run, and test the application locally, mirroring the CI/CD pipeline.

Highlights

  • ADK Configuration Update: The ADK application name was standardized from "cofacts-ai" to "cofacts_ai" across the codebase and file paths to ensure consistency.
  • Local Docker Testing Setup: A new local Docker testing environment was introduced using docker-compose.yml and adk/.dockerignore, enabling developers to build and test frontend and backend Docker images locally.
  • Documentation Enhancement: The README.md was updated to include detailed instructions for the new local Docker testing environment and clarified ADK server URLs for development.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .gitignore
    • Added .adk to ignore local ADK state.
  • README.md
    • Updated ADK agent setup path.
    • Specified local server URLs.
    • Added a new section for local Docker testing instructions.
  • adk/.dockerignore
    • Created a new file to specify files and directories to be ignored in Docker builds.
  • adk/Dockerfile
    • Modified the CMD instruction to use adk api_server instead of adk web.
  • adk/cofacts-ai/.env.example
    • Renamed to adk/cofacts_ai/.env.example.
  • adk/cofacts-ai/agent.py
    • Renamed to adk/cofacts_ai/agent.py.
  • adk/cofacts-ai/instrumentation.py
    • Renamed to adk/cofacts_ai/instrumentation.py.
  • adk/cofacts-ai/tools.py
    • Renamed to adk/cofacts_ai/tools.py.
  • docker-compose.yml
    • Added a new file defining services for local frontend and backend Docker containers, including build contexts, ports, environment variables, and health checks.
  • src/lib/adk.ts
    • Updated the ADK_APP_NAME constant from cofacts-ai to cofacts_ai.
  • src/routes/api/sessions.$sessionId.ts
    • Updated the APP_NAME constant from cofacts-ai to cofacts_ai.
  • src/routes/api/sessions.ts
    • Updated the APP_NAME constant from cofacts-ai to `cofacts_ai'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a local Docker testing setup using Docker Compose, which is a significant improvement for the development workflow. It also refactors the ADK application name from cofacts-ai to cofacts_ai for consistency with Python package naming conventions, and updates the ADK server command. The changes are well-implemented. I have a couple of minor suggestions to improve the documentation and the new Docker Compose configuration for consistency.

Comment thread README.md
Comment thread docker-compose.yml
@MrOrz
Copy link
Copy Markdown
Member Author

MrOrz commented Mar 12, 2026

Works
圖片

@MrOrz MrOrz self-assigned this Mar 12, 2026
@MrOrz MrOrz requested review from andyy0216, bil4444 and nonumpa March 12, 2026 15:06
@MrOrz MrOrz merged commit 8e8bb19 into master Mar 13, 2026
10 checks passed
@MrOrz MrOrz deleted the upgrade-adk branch March 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants