-
Notifications
You must be signed in to change notification settings - Fork 0
Session List and Title Management #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| package-lock.json | ||
| pnpm-lock.yaml | ||
| yarn.lock | ||
| yarn.lock | ||
| service.template.yaml |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,4 +63,4 @@ | |
| "vitest": "^3.0.5", | ||
| "web-vitals": "^5.1.0" | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ spec: | |
| run.googleapis.com/container-dependencies: '{"ingress":["backend"]}' | ||
| autoscaling.knative.dev/minScale: "0" | ||
| autoscaling.knative.dev/maxScale: "3" | ||
| run.googleapis.com/cloudsql-instances: industrious-eye-145611:asia-east1:cofacts | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Cloud SQL instance connection string appears to contain a hardcoded project ID ( run.googleapis.com/cloudsql-instances: ${GCP_PROJECT_ID}:asia-east1:cofacts |
||
| spec: | ||
| containers: | ||
| - name: ingress | ||
|
|
@@ -45,6 +46,8 @@ spec: | |
| value: "${LANGFUSE_SECRET_KEY}" | ||
| - name: LANGFUSE_BASE_URL | ||
| value: "https://langfuse.cofacts.tw" | ||
| - name: DATABASE_URL | ||
| value: "${DATABASE_URL}" | ||
| startupProbe: | ||
| tcpSocket: | ||
| port: 8000 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
root_agentis redefined here after theappobject has been created. This is confusing and likely redundant if the application server is configured to use theappobject, which encapsulates the agent and session service. To improve clarity and maintainability, please consider removing this line if it's not strictly necessary for a specific execution path. If it is required, a comment explaining its purpose would be very helpful.