Skip to content

Add feedback popover with comment for AI responses#31

Merged
MrOrz merged 4 commits into
masterfrom
add-feedback-popover-4792468756137760355
May 3, 2026
Merged

Add feedback popover with comment for AI responses#31
MrOrz merged 4 commits into
masterfrom
add-feedback-popover-4792468756137760355

Conversation

@MrOrz
Copy link
Copy Markdown
Member

@MrOrz MrOrz commented Apr 27, 2026

Adds a Shadcn UI Popover and Checkbox to the FeedbackButtons component. This allows users to provide additional comment alongside their thumbs-up/down score, using a list of predefined reasons and a custom text area. Also handles clearing the feedback if the user clicks the same button again.

Feedback options

thumbs up
語氣適合、篇幅適中、出處精準、具有說服力

thumbs down
篇幅過長、篇幅過短、沒抓到重點、出處不足、回應文字與出處不符、提供不存在的出處、出處摘要錯誤

Cap.2026-05-03.at.03.00.06.mp4

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new UI components for Checkbox and Popover using @base-ui/react primitives. Feedback focuses on improving the robustness and usability of these components, specifically by ensuring the Checkbox maintains a visible error state when checked, adding React.forwardRef to PopoverContent for better DOM access, and expanding the PopoverContent props to support more advanced positioning features.

Comment thread src/components/ui/checkbox.tsx
Comment thread src/components/ui/popover.tsx
Comment thread src/components/ui/popover.tsx
google-labs-jules Bot and others added 3 commits May 2, 2026 19:15
Co-authored-by: MrOrz <108608+MrOrz@users.noreply.github.com>
Co-authored-by: MrOrz <108608+MrOrz@users.noreply.github.com>
Co-authored-by: MrOrz <108608+MrOrz@users.noreply.github.com>
@MrOrz MrOrz force-pushed the add-feedback-popover-4792468756137760355 branch from 3d1df9e to 9d386ec Compare May 2, 2026 11:15
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@MrOrz MrOrz self-assigned this May 2, 2026
@MrOrz MrOrz linked an issue May 2, 2026 that may be closed by this pull request
@MrOrz MrOrz marked this pull request as ready for review May 2, 2026 19:03
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@MrOrz MrOrz merged commit 00a8fe2 into master May 3, 2026
9 checks passed
@MrOrz MrOrz deleted the add-feedback-popover-4792468756137760355 branch May 3, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add feedback buttons to UI

2 participants