fix(FeedbackButtons): wrap each button in its own PopoverTrigger [Trivial]#52
Conversation
Eliminates Base UI warning about non-<button> render in PopoverTrigger by replacing the shared <div> trigger wrapper with individual triggers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Code Review
This pull request refactors the FeedbackButtons component by moving the PopoverTrigger to wrap individual buttons and removing event propagation. The review identifies a bug where the popover closes prematurely when switching between feedback types due to the missing event handling, suggesting the use of e.preventDefault(). Furthermore, the use of multiple PopoverTrigger components within a single Popover is noted as a non-standard pattern that could lead to accessibility and focus management issues.
Summary
PopoverTriggerwrapping a<div>with individualPopoverTriggerper button<button>but received a<div>via therenderprope.stopPropagation()callTest plan
Before
(Only exists on localhost)

After
voting.mp4
🤖 Generated with Claude Code