Update images to use the GHCR repo

[mattbates]

Updated the repo to GHCR and also removed the deploy directory now there'a a Helm chart.

[gemini-code-assist]

Summary of Changes

Hello @mattbates, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on migrating the project's container image hosting from AWS ECR to GitHub Container Registry (GHCR) and simplifying deployment by removing the internal deploy folder in favor of an external Helm chart. Additionally, it includes updates to development tooling, comprehensive documentation improvements, and minor code quality enhancements across various Go files, ensuring a more streamlined development and deployment experience.

Highlights

• Image Registry Migration: All internal references to container images (for spiffe-enable-ui and spiffe-enable-init) have been updated to use GitHub Container Registry (GHCR) instead of the previous AWS ECR repository.
• Deployment Simplification: The deploy folder has been removed from the repository, as the project now relies on an external Helm chart for installation and deployment, streamlining the setup process.
• Development Workflow Enhancements: A new Justfile has been introduced, providing convenient commands for running tests (test, test-race) and linting (lint) using gotestsum and golangci-lint, improving the developer experience.
• Documentation Updates: The README.md has been significantly revised to reflect the new image registry, clarify SPIFFE concepts (e.g., the new csi mode, SVID credentials), and provide updated installation instructions referencing cofidectl and the recommended Helm chart.
• Code Quality and Error Handling Improvements: Minor refactorings were applied in ui/server/main.go and test utilities to improve error handling for Close() operations, explicitly ignore return values from fmt.Fprintf calls, and apply minor Go style adjustments.
• Linter Configuration Adjustment: The .golangci.yml configuration was updated to disable the exportloopref linter and enable copyloopvar, refining the project's code quality checks.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully updates image references to use the GHCR repository, aligning with the main goal. The removal of the deploy directory (as mentioned in the PR description) and the introduction of a Helm chart are significant structural changes that improve deployment management.

Beyond the primary objective, the PR includes several valuable Go code quality improvements:

• Linter configuration updated to use copyloopvar.
• Error handling for Close() methods in deferred calls has been correctly implemented in ui/server/main.go, which is a critical improvement.
• Test files now explicitly ignore fmt.Fprintf return values, adhering to best practices and satisfying linters like errcheck.
• Minor refactorings and stylistic enhancements improve code readability and conciseness.
• The README.md has been updated effectively to reflect the new injection modes, installation instructions, and overall project status.

Overall, the changes are well-executed and enhance both the functionality and maintainability of the codebase. The suggestions provided are mostly of low to medium severity, focusing on minor refinements and best practices.

[gemini-code-assist]

Replacing exportloopref with copyloopvar is a good update. copyloopvar is the successor and more effectively helps prevent issues related to capturing loop variables in closures/goroutines, which can lead to subtle bugs.

[markgoddard]

This could do with a rebase onto main.

[mattbates]

Should be up-to-date with main now?