-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Support AWS with token exchange sidecar injection #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mattbates, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request lays the groundwork for integrating AWS token exchange into the sidecar injection mechanism. The primary functional change involves adding a new annotation to facilitate AWS IAM role specification, complemented by a significant refresh of the project's Go module dependencies to align with newer versions of Kubernetes and other core libraries.
Highlights
- AWS Integration: I've introduced a new Kubernetes pod annotation,
spiffe.cofide.io/aws-role-arn, to enable the specification of AWS IAM Role ARNs. This is a foundational step towards supporting AWS token exchange for sidecar injection. - Dependency Updates: I've performed a comprehensive update of Go module dependencies. This includes bumping versions for core Kubernetes libraries (API, client-go, apimachinery), various
golang.org/xmodules, OpenTelemetry, and other indirect dependencies, ensuring the project uses more recent and stable versions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies and adds a new constant for an AWS-specific annotation. I suggest separating dependency updates into a dedicated pull request and considering a more generic naming scheme for the new annotation.
go.mod
Outdated
| github.com/go-logr/logr v1.4.3 | ||
| github.com/onsi/ginkgo/v2 v2.23.4 | ||
| github.com/onsi/gomega v1.37.0 | ||
| github.com/spiffe/go-spiffe/v2 v2.5.0 | ||
| github.com/stretchr/testify v1.10.0 | ||
| k8s.io/api v0.33.0 | ||
| k8s.io/apimachinery v0.33.0 | ||
| k8s.io/client-go v0.33.0 | ||
| k8s.io/api v0.33.3 | ||
| k8s.io/apimachinery v0.33.3 | ||
| k8s.io/client-go v0.33.3 | ||
| k8s.io/utils v0.0.0-20250502105355-0f33e8f1c979 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal/const/const.go
Outdated
| DebugAnnotation = "spiffe.cofide.io/debug" | ||
| InjectAnnotation = "spiffe.cofide.io/inject" | ||
| DebugAnnotation = "spiffe.cofide.io/debug" | ||
| AWSRoleARNAnnotation = "spiffe.cofide.io/aws-role-arn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.