Use git tag for release artifact versioning #28
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mattbates, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've made a focused change to the .goreleaser.yaml configuration to standardize how release artifacts are versioned. Previously, the configuration used {{ .Version }} for various naming and tagging purposes. This pull request updates all instances to use {{ .Tag }} instead. This change ensures that all generated artifacts, checksums, container images (both ko and Docker), and Docker manifests are consistently versioned directly from the Git tag, providing a more explicit and reliable versioning scheme for releases.
Highlights
- Consistent Artifact Naming: I've updated the
name_templatefor release archives and checksum files to use{{ .Tag }}instead of{{ .Version }}. This ensures that the generated artifact names and their corresponding checksum files directly reflect the Git tag used for the release, providing a more precise and consistent naming convention. - Ko Image Tagging Alignment: I've modified the
tagsconfiguration forkoimages to also use{{ .Tag }}. This change aligns the image tagging with the Git tag, ensuring that container images built withkoare versioned consistently with the release tags. - Docker Image Metadata: I've updated the
org.opencontainers.image.versionlabels within the Docker build configurations to use{{ .Tag }}. This change ensures that the OCI image metadata accurately reflects the Git tag, providing better traceability and versioning information directly within the container images. - Docker Image and Manifest Tagging: I've adjusted the
image_templatesfor all Docker images and their corresponding manifests to use{{ .Tag }}. This ensures that the actual image names pushed to the registry, as well as the multi-architecture manifests, are consistently versioned based on the Git tag.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the GoReleaser configuration to use the git tag ({{.Tag}}) for versioning release artifacts instead of the sanitized version ({{.Version}}). This change is applied consistently to archive names, checksum files, and Docker image tags. My review identifies one area of inconsistency where the version compiled into the application binary itself was not updated, which could lead to confusion. I've recommended a change to align this for consistency.
|
|
||
| archives: | ||
| - name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}" | ||
| - name_template: "{{ .ProjectName }}_{{ .Tag }}_{{ .Os }}_{{ .Arch }}" |
There was a problem hiding this comment.
While you've updated the archive name template to use {{.Tag}}, the version compiled into the binary on line 36 still uses {{.Version}}. This will create a discrepancy between the artifact version in the filename and the version reported by the binary itself (e.g., via a --version flag).
To ensure consistency, you should also update the ldflags to use {{.Tag}}:
ldflags:
- -s -w -X main.version={{.Tag}} -X main.commit={{.ShortCommit}} -X main.date={{.Date}}
Fixes #25.