Refactor envoy config build

[markgoddard]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Envoy configuration build process within the internal/proxy/config.go file. The primary goal is to enhance code organization and maintainability by separating concerns related to parameter initialization and the construction of the Envoy configuration map. This change streamlines the NewEnvoy function, making it more focused on orchestration rather than detailed configuration logic. Additionally, Kubernetes-specific volume and container definitions for the Envoy proxy have been removed from this file, indicating a potential consolidation or relocation of these deployment-related aspects.

Highlights

• Refactored Envoy Configuration Logic: The process of building the Envoy configuration has been refactored by extracting parameter defaulting and the core configuration map construction into dedicated methods on the EnvoyConfigParams struct.
• Improved Modularity: The NewEnvoy function now leverages EnvoyConfigParams.setDefaults() and EnvoyConfigParams.build() for a cleaner and more modular approach to configuration generation.
• Removed Container/Volume Definitions: Functions responsible for generating Kubernetes corev1.Volume and corev1.Container definitions for the Envoy proxy (GetConfigVolume, GetInitContainer, GetSidecarContainer) have been removed from this file, suggesting a relocation or further abstraction of these components.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Envoy configuration building logic by breaking down a large function into smaller, more focused methods. This significantly improves the code's structure, readability, and maintainability. The separation of concerns between preparing the configuration data and generating the Kubernetes resources is well-executed. I have one suggestion to improve error handling.

[yoctozepto]

The diff is awful indeed.