Make Envoy log level configurable

[markgoddard]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the observability of services by making the Envoy proxy's log level configurable. Users can now control the verbosity of Envoy logs by setting a specific annotation on their Kubernetes pods. This change provides greater flexibility for debugging and monitoring, allowing operators to adjust logging detail without modifying the core application configuration.

Highlights

• New Annotation for Envoy Log Level: Introduced a new pod annotation, spiffe.cofide.io/envoy-log-level, allowing users to specify the desired log level for the Envoy proxy sidecar.
• Configurable Envoy Log Level: Modified the Envoy sidecar container creation logic to accept and apply a dynamic log level, passed as a command-line argument to the Envoy process.
• Default Log Level: Implemented a default log level of 'info' for the Envoy sidecar if the spiffe.cofide.io/envoy-log-level annotation is not explicitly set on a pod.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes the Envoy sidecar's log level configurable via a pod annotation. The implementation is straightforward, but I've found a bug where an empty annotation value would cause the Envoy container to fail. I've also suggested an improvement to validate the log level to make the feature more robust. My review comment includes a code suggestion to fix the bug.

[yoctozepto]

Could use having some docs though.

[markgoddard]

Could use having some docs though.

Added a line to the readme.