Skip to content

Conversation

@bammari
Copy link
Collaborator

@bammari bammari commented Mar 19, 2025

This PR is to ensure that the bounds on unscaled output vars are calculated from unscaled input bounds. Likewise, it ensures that bounds on scaled output vars are calculated from scaled input bounds

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.31%. Comparing base (f85e4e1) to head (f492693).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/omlt/linear_tree/lt_formulation.py 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   90.31%   90.31%   -0.01%     
==========================================
  Files          32       32              
  Lines        2014     2034      +20     
  Branches      316      319       +3     
==========================================
+ Hits         1819     1837      +18     
- Misses        123      124       +1     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bammari bammari requested a review from jalving March 19, 2025 22:07
@bammari
Copy link
Collaborator Author

bammari commented Mar 19, 2025

@jalving This PR is to make sure bounds on output vars are calculated correctly.

@jalving jalving merged commit 74d85c0 into cog-imperial:main Mar 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants