Skip to content

Conversation

@bammari
Copy link
Collaborator

@bammari bammari commented Apr 17, 2025

This path is to fix the bug found in issue 173. If a user passes a scaler and scaled input bounds when creating a LinearTreeDefinition, unscaled input bounds will be calculated.

If only scaled input bounds are provided, unscaled input bounds will remain None.

No output bounds will be assigned to unscaled output vars if unscaled input bounds is None.

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.17%. Comparing base (dfe44bd) to head (1be31c4).

Files with missing lines Patch % Lines
src/omlt/linear_tree/lt_formulation.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   91.17%   91.17%   -0.01%     
==========================================
  Files          39       39              
  Lines        3320     3331      +11     
  Branches      509      512       +3     
==========================================
+ Hits         3027     3037      +10     
  Misses        185      185              
- Partials      108      109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bammari bammari requested a review from jalving April 17, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants