Skip to content

updates for Cogent Canvas #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 137 commits into from
Jun 19, 2025
Merged

updates for Cogent Canvas #1528

merged 137 commits into from
Jun 19, 2025

Conversation

rcoreilly
Copy link
Member

@rcoreilly rcoreilly commented May 19, 2025

Some fixes needed to svg and other repos to make Cogent Canvas fully work.

Fixes #1314, fixes #1406

@rcoreilly rcoreilly marked this pull request as draft May 19, 2025 09:01
rcoreilly added 28 commits May 19, 2025 13:22
…ng; key for cogent canvas which updates multiple sprites at a time and otherwise got into corrupted state with some sprites rendered before being all updated. also fixed key issue with path WriteGeom.
…simplifies most of the math involving them, especially on the canvas side.
…ul for many use-cases when viewing an SVG. also fix texteditor update on start of query-replace.
… system to update bound values for both Input and Change events, so it is always fresh. these are needed for proper undo handling in Canvas app.
…or text fields etc, so need this optional method to call when needed.
…t instead of having to search in the code for this every time..
… and body to widgets. also fixed saving of text elements in svg.
…lows the color picker to work. Add missing items to struct-tags docs. Add IconSize to styles: allows easy specification of icon size in a way that can be passed through chooser to the chooser menu -- minimal addition that elegantly solves this problem and makes canvas dashes and markers choosers actually functional.
…rangely missing. doesn't break any tests or demo but might cause a bit more overhead..
…y -- greatly simplifies tree icon size styling. switches needed some different logic but overall cleaner and controlled at the top-level of the switch instead of buried down inside the bits. overall gives the control at the top level where you want it!
… avoid duplicate names; Fixes #1007  Also exported functions needed in Canvas, and added DeleteSelected.
…vg.Group with no color! requires its own visible logic.
… are not exported (enum gen needs to respect that; doesn't currently). colors.Uniform returns nil if source color is nil, instead of a uniform wrapper -- verified this doesn't break any tests.
…rix2 "center" functions which were a wrong version of "about" logic which is now working correctly. also can get rid of the saving of geom stuff and just put gradients on nodes..
…ransforming nodes: use a simple BitCopyFrom of original node data instead of all the custom Read / Write geom, and store the node's own gradient points on the node itself, which gradient properties across new gradients and makes for much easier updating / editing of gradient geom. Got rid of all the faulty math32.Matrix2 center code which was incorrect version of About transforms. Everything is good except for our transform of the radius property on rasterx radius relative to the svg spec
…ale factors and then extract rotation and apply that to point during render, to put back into radius-based reference frame.
kkoreilly and others added 25 commits June 17, 2025 17:16
…focus -- out-of-focus windows don't blink! minimizes any costs associated with this.
…there are many different colors and this is effectively a list of them)
…hat made me break down and write a shared TextCursor method..
Copy link
Member

@kkoreilly kkoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally all good!

@kkoreilly kkoreilly merged commit 68bb6b4 into main Jun 19, 2025
1 of 4 checks passed
@kkoreilly kkoreilly deleted the canvas branch June 19, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab label font size Text Field Icon Sizing is SUPER Awkward
2 participants