Fix for current meetups prematurely becoming past meetups #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Working on the failing test, which is thinking TZ is UTC still... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issue of meetups dropping off the "current" list before they are done.
The change to make Django EST instead of UTC isn't required, but does make things consistent with the timezone the meetups actually occur in. Once this change is made, times in the database will have to be changed as they are currently being stored as UTC.
The view change adds a slack of 4 hours, since the list of current meetups uses the start time of the event to decide when it has passed, this adds 4 hours to "now" as slack. This means the server will continue to show the meetup is current for 4 hours after the start time of the meetup.