[cmake] Add CMake option to enable boost pool support #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the variable `USE_BOOST_POOL` is configured in CMake one could mark this as a `CACHE STRING` variable to make it user-settable. Then the user could enable boost-pool support by setting this variable. However, passing ``` cmake -DUSE_BOOST_POOL='#define USE_BOOST_POOL 1' ``` is rather user unfriendly. Furthermore a binary decision should be configured via a boolean option. Hence, this introduces a CMake option that allows to activate support via ``` cmake -DENABLE_BOOST_POOL=ON ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 66.25% 65.57% -0.68%
==========================================
Files 51 51
Lines 26686 26162 -524
Branches 1843 1843
==========================================
- Hits 17680 17156 -524
Misses 9006 9006
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Notice that this is somehow orthogonal to #87. The latter does not add an option or test for boost-pool. It is also marked as a draft and much more invasive. The present proposal is meant as a short term solution which at least allows to build with cmake and activated boost-pool support, e.g. to test the respective implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the variable
USE_BOOST_POOLis configured in CMake one could mark this as aCACHE STRINGvariable to make it user-settable. Then the user could enable boost-pool support by setting this variable. However, passingis rather user unfriendly. Furthermore a binary decision should be configured via a boolean option. Hence, this introduces a CMake option that allows to activate support via