Skip to content

Conversation

@christoph-cullmann
Copy link
Contributor

CoinUtils/src/CoinFactorization4.cpp:2290:42: runtime error: 2.28294e+09 is outside the range of representable values of type 'int'

@christoph-cullmann
Copy link
Contributor Author

As we only compare it, that seems more sane to me, some overflow could lead to wrong compare results.

@svigerske
Copy link
Member

There are two more places like this, could you change these as well?

CoinFactorization4.cpp:799:      int newNumber = static_cast< int >(number * btranAverageAfterU_);
CoinFactorization4.cpp:1949:      int newNumber = static_cast< int >(number * btranAverageAfterU_);

@christoph-cullmann
Copy link
Contributor Author

Sure, can do that, only did alter first what occurs in my testing.

CoinUtils/src/CoinFactorization4.cpp:2290:42: runtime error: 2.28294e+09 is
outside the range of representable values of type 'int'
@christoph-cullmann
Copy link
Contributor Author

My grep with Kate did show more places that do the same. Should at least covered these now, too.

@svigerske svigerske merged commit ccc23ba into coin-or:master Aug 11, 2025
14 checks passed
@svigerske
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants