fix set partition problem case study docs #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial pass * black + isort * add ignores in pulp.py and pulp/__init__.py * start fixing mypy errors * fix some mypy * mypy passes * move Pattern class definition to be before use
Collaborator
|
Thanks. I think it's ok, go ahead with the rest of examples. |
Contributor
Author
|
I converted one further example and verified that #819 does not move lines around in the remaining files which use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this page https://coin-or.github.io/pulp/CaseStudies/a_set_partitioning_problem.html from the docs is messed up as a result of #819 moving some line numbers around.
This PR fixes the docs and moves to a new style which uses special comments to avoid this happening again in the future. The potential drawback is that the bit at the end where it includes the full file content will now also include these special comments and look a bit funky. I personally think it's worth it but curious on your take.
I suspect there are other docs which are damaged in this same way. Happy to fix but wanted to get your take on the new approach before I do the rest.