Skip to content

Fix: Change registration duration constant type to integer #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Change registration duration constant type to integer #694

wants to merge 1 commit into from

Conversation

Dahka2321
Copy link

Changed REGISTRATION_DURATION from a string "31557600" to an integer 31557600 in constants.py to match the expected uint256 type in contract calls.

File changed:
coinbase_agentkit/action_providers/basename/constants.py

Old: "31557600"
New: 31557600

This avoids unnecessary type conversion during registration.

@Dahka2321 Dahka2321 requested a review from murrlincoln as a code owner April 30, 2025 06:12
@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added action provider New action provider python labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murrlincoln murrlincoln Awaiting requested review from murrlincoln murrlincoln is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action provider New action provider python
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dahka2321 @cb-heimdall