feat(typescript): Add EVM Swap support for EVM Smart Accounts #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
derek-cb
force-pushed
the
evm-swap-support-smartaccounts
branch
from
bb9a5ea to
551a687
Compare
derek-cb
commented
Jun 12, 2025
derek-cb
commented
Jun 12, 2025
0xRAG
reviewed
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for EVM Smart Account swaps:
evmSmartAccount.quoteSwap()evmSmartAccount.swap()swapQuote.execute()(for a swap quote generated by an EVM Smart Account)DevX: see README.md
Miscellaneous:
IdempotencyErrorwhen passing the optionalidempotencyKeyparam into*.swap(), as the sameidempotencyKeywas being used to sign two subsequent API calls.Tests
Checklist
A couple of things to include in your PR for completeness: