-
Notifications
You must be signed in to change notification settings - Fork 17
Add getOrCreateSmartAccount function to EVM #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Heimdall Review Status
|
42bc95f
to
2420f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking pretty good! thanks for your patience on the backend piece. that should have you able to update the e2e tests and also add examples
52d827c
to
9ddb12e
Compare
4f5b088
to
5a733ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. left some comments. almost there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Review Error for sddioulde @ 2025-06-10 22:46:26 UTC |
Description
Add getSmartAccount, createSmartAccount, and getOrCreateSmartAccount to evm.ts with the following signatures:
getOrCreateSmartAccount({ owner, name})
getSmartAccount({owner, name?, address?})
createSmartAccount({owner, name?})
There was some discussion on whether a getOrCreateSmartAccount was necessary but ultimately it was agreed upon adding.
Tests
Added unit tests; waiting on Saliou's merge to do e2e tests and examples
Checklist
A couple of things to include in your PR for completeness: