Skip to content

Add getOrCreateSmartAccount function to EVM #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

superadi04
Copy link
Contributor

@superadi04 superadi04 commented Jun 4, 2025

Description

Add getSmartAccount, createSmartAccount, and getOrCreateSmartAccount to evm.ts with the following signatures:

getOrCreateSmartAccount({ owner, name})
getSmartAccount({owner, name?, address?})
createSmartAccount({owner, name?})

There was some discussion on whether a getOrCreateSmartAccount was necessary but ultimately it was agreed upon adding.

Tests

Added unit tests; waiting on Saliou's merge to do e2e tests and examples

Checklist

A couple of things to include in your PR for completeness:

@superadi04 superadi04 requested review from sddioulde, 0xRAG and jazz-cb June 4, 2025 20:40
@cb-heimdall
Copy link

cb-heimdall commented Jun 4, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@superadi04 superadi04 force-pushed the feat/getOrCreateSmartAccount branch from 42bc95f to 2420f77 Compare June 5, 2025 19:48
Copy link
Contributor

@sddioulde sddioulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking pretty good! thanks for your patience on the backend piece. that should have you able to update the e2e tests and also add examples

@coinbase coinbase deleted a comment from sddioulde Jun 9, 2025
@coinbase coinbase deleted a comment from sddioulde Jun 9, 2025
@coinbase coinbase deleted a comment from sddioulde Jun 9, 2025
@superadi04 superadi04 force-pushed the feat/getOrCreateSmartAccount branch 2 times, most recently from 52d827c to 9ddb12e Compare June 9, 2025 22:32
@superadi04 superadi04 force-pushed the feat/getOrCreateSmartAccount branch from 4f5b088 to 5a733ce Compare June 10, 2025 20:41
@sddioulde sddioulde self-requested a review June 10, 2025 21:46
Copy link
Contributor

@sddioulde sddioulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. left some comments. almost there

@sddioulde sddioulde self-requested a review June 10, 2025 22:43
Copy link
Contributor

@sddioulde sddioulde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cb-heimdall
Copy link

Review Error for sddioulde @ 2025-06-10 22:46:26 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@sddioulde sddioulde self-requested a review June 10, 2025 22:46
@superadi04 superadi04 merged commit c3c0d4c into main Jun 11, 2025
25 checks passed
@superadi04 superadi04 deleted the feat/getOrCreateSmartAccount branch June 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants