Draft
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
hcopp
commented
Apr 23, 2026
| * Whether highlighting tracks specific series. | ||
| */ | ||
| series?: boolean; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
We support series and dataIndex. Our default is dataIndex, which matches existing scrubber logic. Someone might want to select a series if they wanted to highlight all data points for a specific currency or something. This is used by Bar but could be enabled for others in the future.
hcopp
commented
Apr 23, 2026
| @@ -20,6 +20,7 @@ const BRIDGED_CONTEXTS: React.Context<any>[] = [ | |||
| ThemeContext, | |||
| CartesianChartContext, | |||
| ScrubberContext, | |||
Contributor
Author
There was a problem hiding this comment.
We need to keep ScrubberContext in for now.
| */ | ||
| highlightScope?: HighlightScope; | ||
| /** | ||
| * @deprecated Use `enableHighlighting={false}` instead. This will be removed in a future major release. |
Contributor
There was a problem hiding this comment.
should it be enableHighlighting={true}
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityLabel={ | ||
| typeof accessibilityLabel === 'string' ? accessibilityLabel : undefined | ||
| } |
Contributor
There was a problem hiding this comment.
what types can accessibilityLabel be other than string
…ase/cds into hunter/chart-interaction-2
| @@ -628,7 +689,9 @@ export const CartesianChart = memo( | |||
| ) : ( | |||
Contributor
There was a problem hiding this comment.
nit: the nodes in both ternary conditions look very similar, maybe some of them can be memoed and reused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR
enableHighlightingThe PR has a lot of changes for migrating our examples from scrubbing to highlighting, the core logic shift is in CartesianChart and HighlightProvider
Root cause (required for bugfixes)
UI changes
Web
In this example, we render the scrubber beacon at a specific spot when the user wasn't interacting:
In this example, the user interacting with one chart highlights the corresponding date on the other chart.
Highlight by series
Horizontal bar chart interaction
Full customization
Mobile
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false