feat: expose icon glyph and progress circle styles to IconButton#606
Open
feat: expose icon glyph and progress circle styles to IconButton#606
Conversation
…props Adds `styles.icon` (and `classNames.icon` on web) to IconButton on both mobile and web, forwarding them to the inner Icon component so consumers can customize icon glyph appearance (e.g. color, font size). Fixes CDS-1134 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
Contributor
…lass in Storybook Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d docs styles tab - Introduce iconButtonClassNames with root and icon selectors - Replace manual styles/classNames types with StylesAndClassNames utility - Apply static class names to Pressable root and Icon glyph - Add static classNames test - Add _webStyles.mdx and _mobileStyles.mdx doc pages - Wire styles tabs into index.mdx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tory Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hcopp
reviewed
May 4, 2026
…conButton Adds styles.root to mobile IconButton for consistency with other mobile components, and exposes a progressCircle styles/classNames slot on both web and mobile so consumers can customize the loading spinner appearance. Co-authored-by: Cursor <cursoragent@cursor.com>
sverg-cb
force-pushed
the
sverg/icon-button-font-styles
branch
from
8ac0f8c to
41bfcb2
Compare
sverg-cb
changed the title
Use top-level style and className props on ProgressCircle instead of going through the styles/classNames root objects, and update changelogs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adds
styles.iconandstyles.progressCircleto IconButton on both mobile and web (plusclassNames.iconandclassNames.progressCircleon web), forwarding them to the innerIconandProgressCirclecomponents so consumers can customize icon glyph and spinner appearance (e.g. color, font size).Fixes CDS-1134
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false