fix: [CDS-1935] Add selected a11y state to <Cell>#633
Open
maximo-macchi-cb wants to merge 4 commits intomasterfrom
Open
fix: [CDS-1935] Add selected a11y state to <Cell>#633maximo-macchi-cb wants to merge 4 commits intomasterfrom
<Cell>#633maximo-macchi-cb wants to merge 4 commits intomasterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Error
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Error
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
maximo-macchi-cb
had a problem deploying
to
production
GitHub Actions
Failure
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
maximo-macchi-cb
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR updates how the
selectedprop is used so that it applies the needed accessibility API attributes. On web it usesaria-selectedand on mobile it uses React Native'saccessibilityState.Note that for mobile, there's no test file for
<Cell>so the test is added to the<ListCell>unit tests.Root cause (required for bugfixes)
The
selectedprop was not being used to apply these attributes.UI changesTesting
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false