feat: Code Connect Improvements by maximo-macchi-cb · Pull Request #639 · coinbase/cds

maximo-macchi-cb · 2026-04-23T16:27:07Z

What changed? Why?

This PR adds missing Code Connect mappings and adds a PR check to verify new components have Code Connect mappings. There are also some prop updates made which are a result of writing up the new Code Connect mappings.

Root cause (required for bugfixes)

UI changes

Testing

How has it been tested?

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

verified visreg changes with Terran (include link to visreg run/approval)
all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

cb-heimdall · 2026-04-23T16:27:12Z

🟡 Heimdall Review Status

Requirement Status More Info

Reviews

🟡 0/1

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

2 if repo is sensitive 0

From .codeflow.yml 1

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 1

Global minimum 0

Max 1

1

1 if commit is unverified 0

Sum 1

CODEOWNERS 🟡 See below

🟡 `CODEOWNERS`

Code Owner Status Calculation

ui-systems-eng-team

🟡 0/1

Denominator calculation

Additional CODEOWNERS Requirement

Show calculation

Sum	0

0

From CODEOWNERS 1

Sum 1

github-actions · 2026-04-23T18:20:55Z

https://percy.io/d424b72f/web/cds-mobile-visreg-03c97426/builds/49056383

cb-ekuersch · 2026-04-28T17:36:55Z

+          fetch-depth: 100 # TODO: This needs to include the merge-base
+      - uses: ./.github/actions/setup
+      - name: Check for Code Connect Files
+        run: yarn tsx ./tools/ci/validators/validateFigmaCodeConnect.ts


@maximo-macchi-cb you will need to convert to a plain .mjs file - sync with @sverg-cb on your rebase as he just removed TS from this project

cb-ekuersch · 2026-04-28T17:38:13Z

@@ -0,0 +1,5 @@
+import React from 'react';


nit: remove?

cb-ekuersch · 2026-04-28T17:38:32Z

+    imports: ["import { RollingNumber } from '@coinbase/cds-mobile/numbers/RollingNumber'"],
+    example: () => (
+      <RollingNumber
+        font="display1"


there's not figma component properties? 👀

cb-ekuersch · 2026-04-28T17:39:25Z

+figma.connect(Stepper, FIGMA_URL, {
+  variant: { type: 'stepper', platform: '📱 mobile' },
+  imports: ["import { Stepper } from '@coinbase/cds-mobile/stepper'"],
+  example: () => (


won't the steps be invisible? I believe in the stepper component in figma thre is a property that defines the number of steps

cb-ekuersch · 2026-04-28T17:39:51Z

+      }),
+    },
+    example: ({ ...props }) => (
+      <SelectChip {...props} onChange={() => {}} options={selectOptions} value="usd" />


same thing - are the options visible in the code preview window?

cb-ekuersch · 2026-04-28T17:40:04Z

@@ -0,0 +1,5 @@
+import React from 'react';


maximo-macchi-cb added 3 commits April 22, 2026 14:59

ListCell code connect mappings updated

7602dd9

Update Code Connect files from high usage audit

e7ea215

Update PR workflow to show audit results in CI

8781c95

maximo-macchi-cb self-assigned this Apr 23, 2026

maximo-macchi-cb had a problem deploying to github-pages April 23, 2026 16:27 — with GitHub Actions Failure

maximo-macchi-cb had a problem deploying to production April 23, 2026 16:27 — with GitHub Actions Failure

github-actions Bot added packages:web packages:mobile labels Apr 23, 2026

maximo-macchi-cb had a problem deploying to production April 23, 2026 16:27 — with GitHub Actions Failure

use workflow instead'

45176f4

maximo-macchi-cb had a problem deploying to production April 23, 2026 17:49 — with GitHub Actions Error

maximo-macchi-cb had a problem deploying to production April 23, 2026 17:50 — with GitHub Actions Failure

Fix env set up in workflow

948b251

maximo-macchi-cb had a problem deploying to production April 23, 2026 18:00 — with GitHub Actions Error

verify new component files without cc cause flag in workflow

da244e9

maximo-macchi-cb temporarily deployed to production April 23, 2026 18:04 — with GitHub Actions Inactive

Add new Code Connect files

153918b

maximo-macchi-cb temporarily deployed to production April 23, 2026 21:10 — with GitHub Actions Inactive

maximo-macchi-cb temporarily deployed to production April 23, 2026 21:11 — with GitHub Actions Inactive

Update Figma properties

dfc2bb1

maximo-macchi-cb temporarily deployed to production April 23, 2026 21:41 — with GitHub Actions Inactive

maximo-macchi-cb temporarily deployed to production April 23, 2026 21:42 — with GitHub Actions Inactive

Fix ListCell code connect

1dd1b67

maximo-macchi-cb temporarily deployed to production April 23, 2026 22:03 — with GitHub Actions Inactive

maximo-macchi-cb had a problem deploying to production April 23, 2026 22:04 — with GitHub Actions Failure

Add support for handleBar a11y label in SelectChip

1b8750a

maximo-macchi-cb had a problem deploying to production April 27, 2026 22:58 — with GitHub Actions Error

github-actions Bot added the packages:eslint-plugin-cds label Apr 27, 2026

maximo-macchi-cb had a problem deploying to production April 27, 2026 22:59 — with GitHub Actions Error

Merge branch 'master' into max/code-connect-improvements

7bd946d

maximo-macchi-cb temporarily deployed to production April 27, 2026 23:00 — with GitHub Actions Inactive

maximo-macchi-cb had a problem deploying to production April 27, 2026 23:01 — with GitHub Actions Failure

maximo-macchi-cb marked this pull request as ready for review April 27, 2026 23:07

cb-ekuersch reviewed Apr 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Code Connect Improvements#639

feat: Code Connect Improvements#639
maximo-macchi-cb wants to merge 11 commits intomasterfrom
max/code-connect-improvements

maximo-macchi-cb commented Apr 23, 2026 •

edited

Loading

Uh oh!

cb-heimdall commented Apr 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

cb-ekuersch Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

maximo-macchi-cb commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed? Why?

Root cause (required for bugfixes)

UI changes

Testing

How has it been tested?

Testing instructions

Illustrations/Icons Checklist

Change management

Uh oh!

cb-heimdall commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Heimdall Review Status

🟡 CODEOWNERS

Uh oh!

github-actions Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

cb-ekuersch Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

maximo-macchi-cb commented Apr 23, 2026 •

edited

Loading

cb-heimdall commented Apr 23, 2026 •

edited

Loading

🟡 `CODEOWNERS`

github-actions Bot commented Apr 23, 2026 •

edited

Loading