Skip to content

feat: update bgWarning to orange60#659

Merged
adrienzheng-cb merged 2 commits intomasterfrom
adrien/update-bgWarning-token
May 4, 2026
Merged

feat: update bgWarning to orange60#659
adrienzheng-cb merged 2 commits intomasterfrom
adrien/update-bgWarning-token

Conversation

@adrienzheng-cb
Copy link
Copy Markdown
Contributor

What changed? Why?

Root cause (required for bugfixes)

UI changes

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 30, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@maximo-macchi-cb maximo-macchi-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does high contrast theme need to be updated as well?

sverg-cb
sverg-cb previously approved these changes May 4, 2026
@cb-heimdall
Copy link
Copy Markdown
Collaborator

Review Error for sverg-cb @ 2026-05-04 17:18:23 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@sverg-cb sverg-cb dismissed their stale review May 4, 2026 17:19

premature, look into high-contrast theme

Copy link
Copy Markdown
Contributor

@sverg-cb sverg-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified async, hi-contrast keeps its token

@adrienzheng-cb
Copy link
Copy Markdown
Contributor Author

adrienzheng-cb commented May 4, 2026

Does high contrast theme need to be updated as well?

@maximo-macchi-cb No I checked with Mandy. We just need to update the tokens for default and coinbaseTheme. Hight contrast stays at orange80

@adrienzheng-cb adrienzheng-cb merged commit f79a780 into master May 4, 2026
36 checks passed
@adrienzheng-cb adrienzheng-cb deleted the adrien/update-bgWarning-token branch May 4, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants