fix: gate aria-live announcements on chart focus#663
Closed
fix: gate aria-live announcements on chart focus#663
Conversation
Scrubber's aria-live region now switches between 'polite' and 'off' based on whether the chart SVG has DOM focus, preventing screen readers from announcing value changes when the user is elsewhere on the page. Also changes the default accessibilityLiveRegion from 'polite' to 'none' on both web and mobile CartesianChart, and removes the static aria-live attribute from the web SVG element. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
github-actions
Bot
added
packages:mobile-visualization
packages:web-visualization
labels
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrubber's aria-live region now switches between 'polite' and 'off' based on whether the chart SVG has DOM focus, preventing screen readers from announcing value changes when the user is elsewhere on the page. Also changes the default accessibilityLiveRegion from 'polite' to 'none' on both web and mobile CartesianChart, and removes the static aria-live attribute from the web SVG element.
What changed? Why?
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false