enable parsing output address in field of string type#138
Open
alejoacosta74 wants to merge 1 commit intocoinbase:masterfrom
Open
enable parsing output address in field of string type#138alejoacosta74 wants to merge 1 commit intocoinbase:masterfrom
alejoacosta74 wants to merge 1 commit intocoinbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
After Bitcoin core 23.0,
bitcoindno longer returns theaddressesfield in RPC methodsgettxout,getrawtransaction,decoderawtransaction,decodescript,gettransaction verbose=true(see bitcoin release notes for more detail).Instead, a
addressfield is returned, which should be decoded in aAddress stringfield within theScriptPubKeystruct in bitcoin's client types.Solution
This PR contains a fix that supports both the deprecated
Addresses []stringfield and the newAddress stringfield, that will enable Rosetta-bitcoin implementation to be compatible with bitcoin core v23 while maintaining backward compatibility with previous bitcoin releasesProposed code changes
bitcoin/types.gobitcoin/client.goUnit tests for the bitcoin client have been slightly modified to take the new scenario into consideration.
get_block_responses_2_bis.json) which is a copy of the original test data (i.e.get_block_responses_2.json) but with the data fields modified as described above.varwith the corresponding new block (block100000_bis) has been added to the test filebitcoin/client_test.goto update unit tests accordiglyOpen questions
N/A