Fix nil pointer dereference in TraceBlockByHash#162
Open
jcbucb wants to merge 1 commit intocoinbase:masterfrom
Open
Fix nil pointer dereference in TraceBlockByHash#162jcbucb wants to merge 1 commit intocoinbase:masterfrom
jcbucb wants to merge 1 commit intocoinbase:masterfrom
Conversation
Add nil check for tx.Result before accessing tx.Result.Type to prevent panic when debug_traceBlockByHash returns a trace entry with a null result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tx.Resultbefore accessingtx.Result.TypeinTraceBlockByHashdebug_traceBlockByHashreturns a trace entry with a null resultRoot Cause
In
TraceBlockByHash, the code checkstx.Result.Type == ""(line 451) without first checking iftx.Resultis nil. TheResultfield is a pointer (*Call), so when the RPC returns{"result": null}for a trace entry, accessing.Typeon a nil pointer causes a panic.Context
This panic is being observed in production on Sei EVM (rosetta-seievm) during
/blockrequests. The stack trace:Test plan
🤖 Generated with Claude Code